-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
./x check miri: enable check_only feature #150694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r? @clubby789 rustbot has assigned @clubby789. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM; I think it's more useful to keep default_features around. Going to pass this on for the testing:
r? @bjorn3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Works fine with ./x.py check --compile-time-deps and inside rust-analyzer. Both before and after this PR miri takes 5s for compiling the build deps.
|
@bors r=clubby789,bjorn3 |
|
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
./x check miri: enable check_only feature Commit rust-lang#147526 removed the following code and replaced it with the `AllocatorMethod`. However, its input is empty, resulting in behavior inconsistent with the previous code. ```rust create_wrapper_function( tcx, &cx, &mangle_internal_symbol(tcx, "__rust_alloc_error_handler"), Some(&mangle_internal_symbol(tcx, alloc_error_handler_name(alloc_error_handler_kind))), &[usize, usize], // size, align None, true, &CodegenFnAttrs::new(), ); ``` resolves rust-lang#150755
./x check miri: enable check_only feature With this, we should no longer need to turn off the default features, so we can undo rust-lang#149550. @bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended? FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
./x check miri: enable check_only feature With this, we should no longer need to turn off the default features, so we can undo rust-lang#149550. @bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended? FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
Rollup of 11 pull requests Successful merges: - #149976 (Add waker_fn and local_waker_fn to std::task) - #150074 (Update provider API docs) - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets) - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm) - #150569 (Ensure that static initializers are acyclic for NVPTX) - #150607 (Add amdgpu_dispatch_ptr intrinsic) - #150694 (./x check miri: enable check_only feature) - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`) - #150736 (Add AtomicPtr::null) - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl) - #150789 (Fix copy-n-paste error in `vtable_for` docs) r? @ghost
Rollup of 10 pull requests Successful merges: - #149976 (Add waker_fn and local_waker_fn to std::task) - #150074 (Update provider API docs) - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets) - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm) - #150569 (Ensure that static initializers are acyclic for NVPTX) - #150694 (./x check miri: enable check_only feature) - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`) - #150736 (Add AtomicPtr::null) - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl) - #150789 (Fix copy-n-paste error in `vtable_for` docs) r? @ghost
Rollup merge of #150694 - miri-check, r=clubby789,bjorn3 ./x check miri: enable check_only feature With this, we should no longer need to turn off the default features, so we can undo #149550. @bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended? FWIW we could now remove `default_features` from `run_tool_check_step`. Not sure if that's worth it.
With this, we should no longer need to turn off the default features, so we can undo #149550.
@bjorn3 you seem to have a test setup to check if this works properly in terms of skipping all the work that should not be required -- could you test if this PR works as intended?
FWIW we could now remove
default_featuresfromrun_tool_check_step. Not sure if that's worth it.