Skip to content

Use --print target-libdir in run-make tests#150544

Merged
bors merged 1 commit intorust-lang:mainfrom
bjorn3:run_make_print_target_libdir
Dec 31, 2025
Merged

Use --print target-libdir in run-make tests#150544
bors merged 1 commit intorust-lang:mainfrom
bjorn3:run_make_print_target_libdir

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Dec 31, 2025

This makes the tests more robust against sysroot layout changes and slightly simplifies them.

This makes the tests more robust against sysroot layout changes and
slightly simplifies them.
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. r=me

View changes since this review

@jieyouxu
Copy link
Member

@bors r=Urgau,jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Dec 31, 2025

📌 Commit 1a4e7f9 has been approved by Urgau,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2025
bors added a commit that referenced this pull request Dec 31, 2025
…uwer

Rollup of 5 pull requests

Successful merges:

 - #146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly)
 - #150337 (docs: fix typo in std::io::buffered)
 - #150530 (Remove `feature(string_deref_patterns)`)
 - #150543 (`rust-analyzer` subtree update)
 - #150544 (Use --print target-libdir in run-make tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 552918b into rust-lang:main Dec 31, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 31, 2025
rust-timer added a commit that referenced this pull request Dec 31, 2025
Rollup merge of #150544 - bjorn3:run_make_print_target_libdir, r=Urgau,jieyouxu

Use --print target-libdir in run-make tests

This makes the tests more robust against sysroot layout changes and slightly simplifies them.
@bjorn3 bjorn3 deleted the run_make_print_target_libdir branch December 31, 2025 22:03
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Jan 1, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly)
 - rust-lang/rust#150337 (docs: fix typo in std::io::buffered)
 - rust-lang/rust#150530 (Remove `feature(string_deref_patterns)`)
 - rust-lang/rust#150543 (`rust-analyzer` subtree update)
 - rust-lang/rust#150544 (Use --print target-libdir in run-make tests)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Jan 8, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly)
 - rust-lang/rust#150337 (docs: fix typo in std::io::buffered)
 - rust-lang/rust#150530 (Remove `feature(string_deref_patterns)`)
 - rust-lang/rust#150543 (`rust-analyzer` subtree update)
 - rust-lang/rust#150544 (Use --print target-libdir in run-make tests)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants