fix running stdlib doctests in Miri in CI #150458

RalfJung · 2025-12-28T12:26:26Z

RalfJung · 2025-12-28T12:26:52Z

src/bootstrap/mk/Makefile.in

 		$(BOOTSTRAP) miri --stage 2 \
-		library/coretests \
-		library/alloctests \
+		library/core \


This is wired up to run the tests from the separate crates, right?

I don't think that is implemented for ./x.py miri. ./x.py test has this code:

rust/src/bootstrap/src/core/build_steps/test.rs

Lines 3111 to 3120 in 9f54abe

// The core and alloc crates can't directly be tested. We

// could silently ignore them, but adding their own test

// crates is less confusing for users. We still keep core and

// alloc themself for doctests

if crates.iter().any(|crate_| crate_ == "core") {

crates.push("coretests".to_owned());

}

if crates.iter().any(|crate_| crate_ == "alloc") {

crates.push("alloctests".to_owned());

}

But ./x.py miri doesn't.

That code also runs for ./x miri though?

I tried ./x miri library/core -- mem and it said

Running tests/lib.rs (build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/debug/deps/coretests-d8eae4d2db388c62) running 71 tests ....................................................................... test result: ok. 71 passed; 0 failed; 0 ignored; 0 measured; 2201 filtered out; finished in 24.46s Running benches/lib.rs (build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/debug/deps/corebenches-41b71a0680fbdcd6) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 29.49ms Doc-tests core running 113 tests ........................................................................................ 88/113 ......................... test result: ok. 113 passed; 0 failed; 0 ignored; 0 measured; 5467 filtered out; finished in 2.43s all doctests ran in 2.50s; merged doctests compilation took 0.04s Doc-tests coretests running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 12.47µs finished in 55.808 seconds

That looks good to me?

Indeed. I was looking at build_steps::test::Miri, which is for ./x.py test src/tools/miri, not ./x.py miri.

RalfJung · 2025-12-28T12:27:10Z

@bors try jobs=miri

fix running doctests in Miri try-job: *miri*

rust-bors · 2025-12-28T13:53:25Z

☀️ Try build successful (CI)
Build commit: d178db9 (d178db9e5a55eda3463e86f358ad4f5d0deccf2f, parent: 23d01cd2412583491621ab1ca4f1b01e37d11e39)

RalfJung · 2025-12-28T15:05:21Z

That is very strange, I expected the try build to fail since there's a broken doctest...

RalfJung · 2025-12-28T15:27:12Z

Oh wait, that was the wrong job.

@bors try jobs=aux

fix running doctests in Miri try-job: *aux*

rust-log-analyzer · 2025-12-28T17:08:30Z

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    |
    = help: this indicates a bug in the program: it performed an invalid operation, and caused Undefined Behavior
    = help: see https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html for further information
    = note: BACKTRACE:
    = note: inside `main::_doctest_main_library_core_src_mem_maybe_dangling_rs_39_0` at library/core/src/mem/maybe_dangling.rs:15:13: 15:18
note: inside `main`
   --> library/core/src/mem/maybe_dangling.rs:52:3
    |
 52 | } _doctest_main_library_core_src_mem_maybe_dangling_rs_39_0() }
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())`
   --> /checkout/library/core/src/ops/function.rs:250:5
    |
250 |     extern "rust-call" fn call_once(self, args: Args) -> Self::Output;
---
all doctests ran in 505.29s; merged doctests compilation took 0.05s
error: doctest failed, to rerun pass `-p core --doc`
Bootstrap failed while executing `miri --stage 2 library/core library/alloc --doc`
Build completed unsuccessfully in 0:09:46
make: *** [Makefile:56: check-aux] Error 1
  local time: Sun Dec 28 17:08:16 UTC 2025
  network time: Sun, 28 Dec 2025 17:08:16 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

rust-bors · 2025-12-28T17:08:39Z

💔 Test for 8c1f4ee failed: CI. Failed jobs:

try - x86_64-gnu-aux (web logs, enhanced plaintext logs)

RalfJung · 2025-12-28T17:27:24Z

Nice. And now it should be fixed.

@bors try jobs=aux

fix running doctests in Miri try-job: *aux*

rust-bors · 2025-12-28T19:34:07Z

☀️ Try build successful (CI)
Build commit: 084978e (084978ecbaddcb161b9963a2408f2382a918b993, parent: 7eadf834b536d0659c7445e2b0970316b55abde4)

bjorn3 · 2025-12-29T08:41:14Z

@bors r+

bors · 2025-12-29T08:41:17Z

📌 Commit a4b4cd5 has been approved by bjorn3

It is now in the queue for this repository.

fix running stdlib doctests in Miri in CI r? ``@bjorn3``

Rollup of 6 pull requests Successful merges: - #150108 (Offload: Build offload as a single Step) - #150262 (slice iter cleanup: replace checked_sub with saturating_sub) - #150427 (add has_offload/needs-offload to the test infra) - #150458 (fix running stdlib doctests in Miri in CI) - #150477 (Fix enum variant suggestion consuming trailing parenthesis) - #150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150458 - RalfJung:miri-doctests, r=bjorn3 fix running stdlib doctests in Miri in CI r? `@bjorn3`

Rollup of 6 pull requests Successful merges: - rust-lang/rust#150108 (Offload: Build offload as a single Step) - rust-lang/rust#150262 (slice iter cleanup: replace checked_sub with saturating_sub) - rust-lang/rust#150427 (add has_offload/needs-offload to the test infra) - rust-lang/rust#150458 (fix running stdlib doctests in Miri in CI) - rust-lang/rust#150477 (Fix enum variant suggestion consuming trailing parenthesis) - rust-lang/rust#150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup

fix running doctests in Miri

391c819

rustbot assigned bjorn3 Dec 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 28, 2025

RalfJung commented Dec 28, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 28, 2025

Auto merge of #150458 - RalfJung:miri-doctests, r=<try>

d178db9

fix running doctests in Miri try-job: *miri*

disable a doctests that does not work yet

a4b4cd5

RalfJung force-pushed the miri-doctests branch from a4b4cd5 to 391c819 Compare December 28, 2025 15:26

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 28, 2025

Auto merge of #150458 - RalfJung:miri-doctests, r=<try>

8c1f4ee

fix running doctests in Miri try-job: *aux*

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Dec 28, 2025

Auto merge of #150458 - RalfJung:miri-doctests, r=<try>

084978e

fix running doctests in Miri try-job: *aux*

RalfJung changed the title ~~fix running doctests in Miri~~ fix running stdlib doctests in Miri in CI Dec 28, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2025

matthiaskrgr mentioned this pull request Dec 29, 2025

Rollup of 6 pull requests #150481

Merged

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 29, 2025

Rollup merge of rust-lang#150458 - RalfJung:miri-doctests, r=bjorn3

8f831f0

fix running stdlib doctests in Miri in CI r? ``@bjorn3``

JonathanBrouwer mentioned this pull request Dec 29, 2025

Rollup of 6 pull requests #150482

Closed

bors merged commit fc8230f into rust-lang:main Dec 29, 2025
23 checks passed

rustbot added this to the 1.94.0 milestone Dec 29, 2025

rust-timer added a commit that referenced this pull request Dec 29, 2025

Unrolled build for #150458

867c733

Rollup merge of #150458 - RalfJung:miri-doctests, r=bjorn3 fix running stdlib doctests in Miri in CI r? `@bjorn3`

RalfJung deleted the miri-doctests branch January 1, 2026 11:33

	// The core and alloc crates can't directly be tested. We
	// could silently ignore them, but adding their own test
	// crates is less confusing for users. We still keep core and
	// alloc themself for doctests
	if crates.iter().any(\|crate_\| crate_ == "core") {
	crates.push("coretests".to_owned());
	}
	if crates.iter().any(\|crate_\| crate_ == "alloc") {
	crates.push("alloctests".to_owned());
	}

Uh oh!

fix running stdlib doctests in Miri in CI #150458

fix running stdlib doctests in Miri in CI #150458

Conversation

RalfJung commented Dec 28, 2025

Uh oh!

RalfJung Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Dec 28, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 28, 2025

Uh oh!

RalfJung commented Dec 28, 2025

Uh oh!

RalfJung commented Dec 28, 2025

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Dec 28, 2025

Uh oh!

rust-bors bot commented Dec 28, 2025

Uh oh!

RalfJung commented Dec 28, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Dec 28, 2025

Uh oh!

bjorn3 commented Dec 29, 2025

Uh oh!

bors commented Dec 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants