Skip to content

Fix typo in comment in rustc_errors#148882

Merged
bors merged 2 commits intorust-lang:mainfrom
20jasper:patch-1
Nov 23, 2025
Merged

Fix typo in comment in rustc_errors#148882
bors merged 2 commits intorust-lang:mainfrom
20jasper:patch-1

Conversation

@20jasper
Copy link
Contributor

@20jasper 20jasper commented Nov 12, 2025

It seems "CharPose" was a typo since I couldn't find any references to it anywhere else in the codebase

@20jasper
Fix typo in comment in rustc_errors
41e236a 
It seems "CharPose" was a typo since I couldn't find any references to it anywhere else in the codebase
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nnethercote
Copy link
Contributor

nnethercote commented Nov 12, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2025

📌 Commit 41e236a has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
Kivooeo
Kivooeo reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please change this to lowercase

View changes since this review

@Kivooeo
Copy link
Member

Kivooeo commented Nov 12, 2025

@bors r-

sorry for interrupting, but this Usize looks painful to me

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
@20jasper @Kivooeo
lowercase usize
548b5d2 
Co-authored-by: Kivooeo <75776246+Kivooeo@users.noreply.github.com>
@20jasper
Copy link
Contributor Author

20jasper commented Nov 23, 2025

@Kivooeo no problem! Good catch

@Kivooeo
Copy link
Member

Kivooeo commented Nov 23, 2025

Thanks!

@bors r=nnethercote,Kivooeo rollup

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

📌 Commit 548b5d2 has been approved by nnethercote,Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2025
@bors
Copy link
Collaborator

bors commented Nov 23, 2025

⌛ Testing commit 548b5d2 with merge c268b39...

@bors bors mentioned this pull request Nov 23, 2025
Merged
@bors
Copy link
Collaborator

bors commented Nov 23, 2025

☀️ Test successful - checks-actions
Approved by: nnethercote,Kivooeo
Pushing c268b39 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2025
@bors bors merged commit c268b39 into rust-lang:main Nov 23, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e0e204f (parent) -> c268b39 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard c268b399848d0efea82d02605d95bcb395add952 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-distcheck: 7030.9s -> 8870.4s (+26.2%)
  2. aarch64-apple: 7299.1s -> 9128.3s (+25.1%)
  3. i686-gnu-nopt-1: 6733.2s -> 8233.5s (+22.3%)
  4. x86_64-gnu-llvm-20: 2437.7s -> 2900.0s (+19.0%)
  5. x86_64-gnu-tools: 3130.2s -> 3712.1s (+18.6%)
  6. x86_64-rust-for-linux: 2619.3s -> 3080.9s (+17.6%)
  7. x86_64-gnu-aux: 6486.9s -> 7548.8s (+16.4%)
  8. pr-check-1: 1695.7s -> 1958.9s (+15.5%)
  9. dist-i586-gnu-i586-i686-musl: 4675.7s -> 5347.6s (+14.4%)
  10. x86_64-gnu-miri: 4346.7s -> 4928.9s (+13.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 23, 2025

Finished benchmarking commit (c268b39): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Cycles

Results (secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.6% [3.6%, 3.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.131s -> 469.133s (0.21%)
Artifact size: 386.25 MiB -> 386.20 MiB (-0.01%)

makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#148882 - 20jasper:patch-1, r=nnethercote,Kivooeo
07ef8ac 
Fix typo in comment in rustc_errors

It seems "CharPose" was a typo since I couldn't find any references to it anywhere else in the codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo left review comments

@nnethercote nnethercote nnethercote approved these changes

Assignees

@nnethercote nnethercote

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@20jasper @rustbot @nnethercote @bors @Kivooeo @rust-timer