Skip to content

Provide more general note for borrowing outside of closure#148552

Merged
bors merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-148392-closure-diag
Nov 12, 2025
Merged

Provide more general note for borrowing outside of closure#148552
bors merged 1 commit intorust-lang:mainfrom
chenyukang:yukang-fix-148392-closure-diag

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 6, 2025 •
edited by rustbot
Loading

Fixes #148392

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang chenyukang force-pushed the yukang-fix-148392-closure-diag branch from c70f246 to 883b2dc Compare November 6, 2025 04:15
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 12, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 12, 2025

📌 Commit 883b2dc has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
@bors
Copy link
Collaborator

bors commented Nov 12, 2025

⌛ Testing commit 883b2dc with merge d6deffe...

@bors
Copy link
Collaborator

bors commented Nov 12, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing d6deffe to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 12, 2025
@bors bors merged commit d6deffe into rust-lang:main Nov 12, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2fcbda6 (parent) -> d6deffe (this PR)

Test differences

Show 4 test diffs

Stage 1

  • [ui] tests/ui/borrowck/borrowed-data-escapes-closure-148392.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/borrowck/borrowed-data-escapes-closure-148392.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d6deffe2debecc66501e50f9573214139ab4d678 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 4251.9s -> 5042.8s (+18.6%)
  2. x86_64-msvc-1: 9322.2s -> 10590.5s (+13.6%)
  3. x86_64-msvc-2: 6402.0s -> 7129.0s (+11.4%)
  4. aarch64-msvc-2: 5620.6s -> 4985.4s (-11.3%)
  5. dist-s390x-linux: 5033.3s -> 5513.9s (+9.5%)
  6. x86_64-msvc-ext1: 7952.2s -> 7196.0s (-9.5%)
  7. dist-aarch64-apple: 7681.8s -> 8362.5s (+8.9%)
  8. dist-apple-various: 4869.5s -> 4439.4s (-8.8%)
  9. x86_64-rust-for-linux: 2724.4s -> 2531.7s (-7.1%)
  10. dist-powerpc-linux: 4762.5s -> 5087.4s (+6.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 12, 2025

Finished benchmarking commit (d6deffe): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.6%, secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.6% [2.6%, 2.6%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-3.4%, -2.4%] 4
All ❌✅ (primary) 2.6% [2.6%, 2.6%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.886s -> 475.901s (0.21%)
Artifact size: 391.10 MiB -> 391.07 MiB (-0.01%)

makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge of rust-lang#148552 - chenyukang:yukang-fix-148392-closure…
8419724 
…-diag, r=petrochenkov

Provide more general note for borrowing outside of closure

Fixes rust-lang#148392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Diagnostic points to code with no explanation

5 participants

@chenyukang @rustbot @petrochenkov @bors @rust-timer