Skip to content

Unify and deduplicate max recip float tests#147818

Merged
bors merged 1 commit intorust-lang:masterfrom
rperier:unify_and_dedup_max_recip_float_tests
Oct 26, 2025
Merged

Unify and deduplicate max recip float tests#147818
bors merged 1 commit intorust-lang:masterfrom
rperier:unify_and_dedup_max_recip_float_tests

Conversation

@rperier
Copy link
Contributor

@rperier rperier commented Oct 17, 2025 •
edited by rustbot
Loading

cc #141726

This is a proposal to unify and deduplicate max recip tests for f16 and f128

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rperier
Copy link
Contributor Author

rperier commented Oct 17, 2025

r? tgross35

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from 8e132eb to 401c80f Compare October 17, 2025 18:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from 401c80f to cd0dfd9 Compare October 18, 2025 16:17
@rperier
Copy link
Contributor Author

rperier commented Oct 18, 2025

r? rust-lang/libs

@rustbot rustbot assigned ibraheemdev and unassigned tgross35 Oct 18, 2025
tgross35
tgross35 requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this going!

r? tgross35

View changes since this review

@rustbot rustbot assigned tgross35 and unassigned ibraheemdev Oct 22, 2025
@tgross35 tgross35 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2025
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from cd0dfd9 to 0c1b7f1 Compare October 25, 2025 15:51
@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rperier
Copy link
Contributor Author

rperier commented Oct 25, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2025
@rperier rperier force-pushed the unify_and_dedup_max_recip_float_tests branch from 0c1b7f1 to 70876ee Compare October 25, 2025 15:57
@tgross35
Copy link
Contributor

tgross35 commented Oct 25, 2025

Thank you!
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 25, 2025

📌 Commit 70876ee has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 26, 2025
@Zalathar
Rollup merge of rust-lang#147818 - rperier:unify_and_dedup_max_recip_…
420214a 
…float_tests, r=tgross35

Unify and deduplicate max recip float tests

cc rust-lang#141726

This is a proposal to unify and deduplicate max recip tests for f16 and f128
@Zalathar Zalathar mentioned this pull request Oct 26, 2025
Closed
bors added a commit that referenced this pull request Oct 26, 2025
@bors
Auto merge of #148120 - Zalathar:rollup-xzrn9a0, r=Zalathar
b74c1e7 
Rollup of 3 pull requests

Successful merges:

 - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const)
 - #145665 (Don't require `T: RefUnwindSafe` for `vec::IntoIter<T>: UnwindSafe`)
 - #147818 (Unify and deduplicate max recip float tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Oct 26, 2025

⌛ Testing commit 70876ee with merge e517798...

@bors
Copy link
Collaborator

bors commented Oct 26, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing e517798 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2025
@bors bors merged commit e517798 into rust-lang:master Oct 26, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing cc63a0a (parent) -> e517798 (this PR)

Test differences

Show 5 test diffs

Stage 1

  • floats::f16::test_max_recip: pass -> [missing] (J0)

Stage 2

  • floats::f16::test_max_recip: pass -> [missing] (J1)
  • floats::f128::test_max_recip: pass -> [missing] (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e5177985a5493c783d6ba20960d2723d9d2e9214 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 8557.5s -> 11071.4s (29.4%)
  2. dist-aarch64-apple: 5726.1s -> 7138.3s (24.7%)
  3. x86_64-gnu-tools: 3762.0s -> 3264.5s (-13.2%)
  4. aarch64-gnu-debug: 4175.0s -> 3679.6s (-11.9%)
  5. pr-check-1: 1681.7s -> 1486.9s (-11.6%)
  6. aarch64-gnu-llvm-20-1: 3765.6s -> 3384.7s (-10.1%)
  7. x86_64-gnu-gcc: 3301.1s -> 2981.3s (-9.7%)
  8. x86_64-gnu-nopt: 6749.0s -> 7392.6s (9.5%)
  9. x86_64-gnu-llvm-20-1: 3261.4s -> 2962.7s (-9.2%)
  10. armhf-gnu: 5113.6s -> 4683.0s (-8.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 26, 2025

Finished benchmarking commit (e517798): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.6%, -0.1%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.029s -> 475.08s (0.01%)
Artifact size: 390.46 MiB -> 390.51 MiB (0.01%)

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge of rust-lang#147818 - rperier:unify_and_dedup_max_recip_fl…
9fc3de3 
…oat_tests, r=tgross35

Unify and deduplicate max recip float tests

cc rust-lang#141726

This is a proposal to unify and deduplicate max recip tests for f16 and f128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

8 participants

@rperier @rustbot @rust-log-analyzer @tgross35 @bors @rust-timer @Mark-Simulacrum @ibraheemdev