std: Move dynamic_lib from std::unstable to std#14763
Closed
brson wants to merge 1 commit intorust-lang:masterfrom
Closed
std: Move dynamic_lib from std::unstable to std#14763brson wants to merge 1 commit intorust-lang:masterfrom
brson wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
This may also make sense in |
This leaves a deprecated reexport in place temporarily. Closes rust-lang#1457.
Contributor
Author
|
This also tags |
Contributor
|
Leaving deprecated reexports are still generally considered breaking changes, as I understand it. However, I don't think any changes to |
bors
added a commit
that referenced
this pull request
Jun 10, 2014
Closes #14611 (std: Remove the as_utf16_p functions) Closes #14694 (Num cleanup) Closes #14760 (Add --color to test binary options) Closes #14763 (std: Move dynamic_lib from std::unstable to std) Closes #14766 (Add test for issue #13446) Closes #14769 (collections: Add missing Default impls) Closes #14773 (General nits) Closes #14776 (rustdoc: Correctly classify enums/typedefs)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Fix manual formatting and remove duplicate command
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 15, 2025
…ust-lang#14770) The problem is that `check_fn` is triggered by both function and closure, and `visit_expr` can visit expressions in another closures within a function or closure. So just skip walking in a inner closure. changelog: Fix [`unnecessary_unwrap`] emitted twice in closure which inside in a function or another closure. Fixes: rust-lang/rust-clippy#14763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves a deprecated reexport in place temporarily.
Closes #1457.
I didn't mark this a breaking change because of the deprecated reexport.