Print tip for human error format in runtest#147429
Conversation
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
src/tools/compiletest/src/runtest.rs
Outdated
| prefix = self.error_prefix(), | ||
| n = not_found.len(), | ||
| ); | ||
| if let Some(human_format) = self |
There was a problem hiding this comment.
Ideally, we wouldn't check this here but at the place where we actually parse error annotations.
It would be cool if we could reuse the (negated) heuristic inside normalize_output (the let json = … one) but it's probably not feasible presently (and we should wait for the rewrite).
There was a problem hiding this comment.
If you don't have the time or inclination to try and move it there, that's fine, too. Could you maybe add a FIXME tho?
|
If you have the time and energy to properly address #147429 (comment) and #147429 (comment), then please go for it! Otherwise, could you add FIXMEs instead? Then r=me after squash |
c7cb3ea to
9e1cdf9
Compare
9e1cdf9 to
f8ee9f0
Compare
|
Thanks, added FIXME. @bors r=fmease |
Rollup of 7 pull requests Successful merges: - #145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - #147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - #147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - #147418 (Fix target list of `link_section`) - #147429 (Print tip for human error format in runtest) - #147441 (Fix comments error for Provenance impls) - #147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#145943 (stdlib docs: document lifetime extension for `format_args!`'s arguments) - rust-lang#147243 (cmse: disallow `impl Trait` in `cmse-nonsecure-entry` return types) - rust-lang#147402 ([rustdoc] Don't serialize & deserialize data that doesn't go OTW) - rust-lang#147418 (Fix target list of `link_section`) - rust-lang#147429 (Print tip for human error format in runtest) - rust-lang#147441 (Fix comments error for Provenance impls) - rust-lang#147442 (c-variadic: fix thir-print for `...` without a pattern) r? `@ghost` `@rustbot` modify labels: rollup
When working on #147354, spent some time to figure out that there is
//~ ERRORleft on test file, this PR will give a better error message for this scenario.