rustc: Remove ~[T] from the language#14703
Conversation
|
When you say that |
|
For now they both signal a parser error, but after awhile I'd like to remove the parser hacks and allow them to become |
|
Sounds good to me. |
There was a problem hiding this comment.
I was under the impression this was meant to be a long term thing?
There was a problem hiding this comment.
As with Box<[T, ..N]>, I figured this could be added back in a principled manner once DST landed. Do you think we should leave the trait definition for now?
There was a problem hiding this comment.
I'm fine with it disappearing... if there's a need for it in future then it can reappear then.
|
Nice diffstat. ❤️ |
|
I'm in the middle of doing this properly for the DST work. I find it useful to preserve existing behaviour rather than rip it out and start again (in particular, there are bugs I've found purely because we have this stuff in the libraries and which we did not have tests for, I'm sure it will happen again). Is there any urgency for doing this right now? |
|
@nick29581 The existence of both |
|
I'd like to take the same route as |
The following features have been removed * box [a, b, c] * ~[a, b, c] * box [a, ..N] * ~[a, ..N] * ~[T] (as a type) * deprecated_owned_vector lint All users of ~[T] should move to using Vec<T> instead.
The following features have been removed * `box [a, b, c]` * `~[a, b, c]` * `box [a, ..N]` * `~[a, ..N]` * `~[T]` (as a type) * deprecated_owned_vector lint All users of ~[T] should move to using Vec<T> instead.
…tering, r=lnicola fix: generate delegate methods filters out functions that already exist on the struct's impls fixes rust-lang#14703
changelog: [`transmute_float_to_int, transmute_int_to_char, transmute_int_to_float`, `transmute_num_to_bytes`]: remove lints, now in rustc these lints are now mostly in rustc, so they dont need to be in clippy anymore rust-lang#136083 (comment) pending rust-lang#140431: transmute_int_to_bool <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - ["Rust version of new lints should be checked" by @samueltardieu](rust-lang/rust-clippy#14703 (comment)) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more <!-- TRIAGEBOT_SUMMARY_DATA_START$${"entries_by_url":{"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576":{"title":"Rust version of new lints should be checked","comment_url":"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576","author":"samueltardieu"}}}$$TRIAGEBOT_SUMMARY_DATA_END --> <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
changelog: [`transmute_float_to_int, transmute_int_to_char, transmute_int_to_float`, `transmute_num_to_bytes`]: remove lints, now in rustc these lints are now mostly in rustc, so they dont need to be in clippy anymore rust-lang#136083 (comment) pending rust-lang#140431: transmute_int_to_bool <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> - ["Rust version of new lints should be checked" by @samueltardieu](rust-lang/rust-clippy#14703 (comment)) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more <!-- TRIAGEBOT_SUMMARY_DATA_START$${"entries_by_url":{"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576":{"title":"Rust version of new lints should be checked","comment_url":"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576","author":"samueltardieu"}}}$$TRIAGEBOT_SUMMARY_DATA_END --> <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
changelog: [`transmute_float_to_int, transmute_int_to_char, transmute_int_to_float`, `transmute_num_to_bytes`]: remove lints, now in rustc these lints are now mostly in rustc, so they dont need to be in clippy anymore rust-lang#136083 (comment) pending rust-lang#140431: transmute_int_to_bool <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> - ["Rust version of new lints should be checked" by @samueltardieu](rust-lang/rust-clippy#14703 (comment)) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more <!-- TRIAGEBOT_SUMMARY_DATA_START$${"entries_by_url":{"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576":{"title":"Rust version of new lints should be checked","comment_url":"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576","author":"samueltardieu"}}}$$TRIAGEBOT_SUMMARY_DATA_END --> <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
changelog: [`transmute_float_to_int, transmute_int_to_char, transmute_int_to_float`, `transmute_num_to_bytes`]: remove lints, now in rustc these lints are now mostly in rustc, so they dont need to be in clippy anymore rust-lang#136083 (comment) pending rust-lang#140431: transmute_int_to_bool <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> - ["Rust version of new lints should be checked" by @samueltardieu](rust-lang/rust-clippy#14703 (comment)) Generated by triagebot, see [help](https://forge.rust-lang.org/triagebot/note.html) for how to add more <!-- TRIAGEBOT_SUMMARY_DATA_START$${"entries_by_url":{"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576":{"title":"Rust version of new lints should be checked","comment_url":"https://github.com/rust-lang/rust-clippy/pull/14703#issuecomment-2861982576","author":"samueltardieu"}}}$$TRIAGEBOT_SUMMARY_DATA_END --> <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
The following features have been removed
box [a, b, c]~[a, b, c]box [a, ..N]~[a, ..N]~[T](as a type)All users of ~[T] should move to using Vec instead.