Conversation
Use deref coercion to let the compiler remove any amount of references.
* revise comments explaining why we are using literal or expression * add unspecified precision comments as we don't guarantee precision * use expression in `f128::to_degrees()` * make `f64::to_degrees()` impl consistent with other functions
add Option::reduce Tracking issue: rust-lang#144273
…=tgross35 Simplify macro generating ToString implementations for `&…&str` Use deref coercion to let the compiler remove any amount of references. Also use that macro for `Cow` and `String`.
…iteral, r=beetrees,tgross35 improve float to_degrees/to_radians rounding comments and impl This PR makes `to_degrees()` and `to_radians()` float functions more consistent between each other and improves comments around their precision and rounding. * revise comments explaining why we are using literal or expression * add unspecified precision comments as we don't guarantee precision * use expression in `f128::to_degrees()` * make `f64::to_degrees()` impl consistent with other functions r? `@tgross35`
…obzol Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml` It lets us avoid a lot of repetition of crate versions, etc. I've just done a few as a start. Many more can be done in follow-ups. r? `@Kobzol`
Inherit TCC in debuginfo tests on macOS macOS has a system for propagating folder permissions, which LLDB disables when spawning processes, which in turn causes debuginfo tests to spam the user with repeated pop-ups asking for permissions. See the code comment for details, as well as the following video for an example of how this looks in practice: https://github.com/user-attachments/assets/1e54f5b8-9130-4b59-8e92-1db1e58fb361 I stumbled upon the incantation to fix this (`settings set target.inherit-tcc true`) while investigating slowdowns when spawning newly created binaries due to XprotectService, see [this Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/build.20scripts.20slow.20on.20macOS.3F). This would allow me to no longer have a `build.build-dir = "/Users/madsmtm/rust-build"` workaround in my `bootstrap.toml`.
Stop calling unwrap when format foreign has trailing dollar Fixes rust-lang#137580
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b2dd217 (parent) -> 3c91be7 (this PR) Test differencesShow 333 test diffsStage 1
Stage 2
Additionally, 329 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3c91be712d3d84f6345cd22eae34c47b3a22a3d3 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (3c91be7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.6%, secondary 4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.9%, secondary -2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 468.683s -> 468.329s (-0.08%) |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#144274 (add Option::reduce) - rust-lang#145562 (Simplify macro generating ToString implementations for `&…&str`) - rust-lang#145625 (improve float to_degrees/to_radians rounding comments and impl) - rust-lang#145740 (Introduce a `[workspace.dependencies`] section in the top-level `Cargo.toml`) - rust-lang#145885 (Inherit TCC in debuginfo tests on macOS) - rust-lang#145905 (Stop calling unwrap when format foreign has trailing dollar) r? `@ghost` `@rustbot` modify labels: rollup
Successful merges:
&…&str#145562 (Simplify macro generating ToString implementations for&…&str)[workspace.dependencies] section in the top-levelCargo.toml#145740 (Introduce a[workspace.dependencies] section in the top-levelCargo.toml)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup