Allow an Iterator to update a &mut [T], add IterReader#14568
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 5, 2014
Merged
Allow an Iterator to update a &mut [T], add IterReader#14568bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
|
src/libcore/slice.rs
Outdated
Member
There was a problem hiding this comment.
Would something like this suffice?
fn update<I: Iterator<T>>(self, iter: I) -> uint {
let mut i = 0;
for (slot, element) in self.mut_iter().zip(iter) {
*slot = element;
i += 1;
}
return i;
}If the unsafe blocks stays, could you add a comment explaining why it is unsafe, what the benefits are, and why it is necessary to not rely on safe code?
Contributor
Author
There was a problem hiding this comment.
You're right, that could work. I'll remove that patch from the PR.
Member
|
The first patch does seem to deviate a bit from the compositionality of iterators. This would add an |
bors
added a commit
that referenced
this pull request
Jun 5, 2014
This PR adds two features to make it possible to transform an `Iterator<u8>` into a `Reader`. The first patch adds a method to mutable slices that allows it to be updated with an `Iterator<T>` without paying for the bounds cost. The second adds a Iterator adaptor, `IterReader`, to provide that `Reader` interface. I had two questions. First, are these named the right things? Second, should `IterReader` instead wrap an `Iterator<Result<u8, E>>`? This would allow you to `IterReader::new(rdr.bytes())`, which could be useful if you want to apply some iterator transformations on a reader while still exporting the Reader interface, but I'd expect there'd be a lot of overhead annotating each byte with an error result.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
…st-lang#14568) Fixes rust-lang/rust-clippy#14449, introduced in rust-lang#14314 changelog: [`map_entry`]: fix a false positive where the lint would trigger without any insert calls present
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 8, 2025
…st-lang#14568) Fixes rust-lang/rust-clippy#14449, introduced in rust-lang#14314 changelog: [`map_entry`]: fix a false positive where the lint would trigger without any insert calls present
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2025
…st-lang#14568) Fixes rust-lang/rust-clippy#14449, introduced in rust-lang#14314 changelog: [`map_entry`]: fix a false positive where the lint would trigger without any insert calls present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two features to make it possible to transform an
Iterator<u8>into aReader. The first patch adds a method to mutable slices that allows it to be updated with anIterator<T>without paying for the bounds cost. The second adds a Iterator adaptor,IterReader, to provide thatReaderinterface.I had two questions. First, are these named the right things? Second, should
IterReaderinstead wrap anIterator<Result<u8, E>>? This would allow you toIterReader::new(rdr.bytes()), which could be useful if you want to apply some iterator transformations on a reader while still exporting the Reader interface, but I'd expect there'd be a lot of overhead annotating each byte with an error result.