Skip to content

Sometimes skip over tokens in parse_token_tree.#145348

Merged
bors merged 1 commit intorust-lang:masterfrom
nnethercote:parse_token_tree-speedup-for-uom
Aug 20, 2025
Merged

Sometimes skip over tokens in parse_token_tree.#145348
bors merged 1 commit intorust-lang:masterfrom
nnethercote:parse_token_tree-speedup-for-uom

Conversation

@nnethercote
Copy link
Contributor

@nnethercote nnethercote commented Aug 13, 2025 •
edited
Loading

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2025
@nnethercote
Copy link
Contributor Author

nnethercote commented Aug 13, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Aug 13, 2025
@rust-bors
Auto merge of #145348 - nnethercote:parse_token_tree-speedup-for-uom,…
654bdaa 
… r=<try>

Sometimes skip over tokens in `parse_token_tree`.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2025
@rust-bors
Copy link
Contributor

rust-bors bot commented Aug 13, 2025

☀️ Try build successful (CI)
Build commit: 654bdaa (654bdaae809cf60c7c5682520b31acf310562481, parent: 1c9952f4dd6e0947ee91f07130c03813a088a894)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Aug 13, 2025

Finished benchmarking commit (654bdaa): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.5% [-0.9%, -0.3%] 18
Improvements ✅
(secondary)		 -1.4% [-2.0%, -0.1%] 9
All ❌✅ (primary) -0.5% [-0.9%, -0.3%] 18

Max RSS (memory usage)

Results (secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.3% [-3.6%, -2.9%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary 5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.6% [5.6%, 5.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.78s -> 464.927s (-0.18%)
Artifact size: 377.44 MiB -> 377.41 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2025
@nnethercote
Sometimes skip over tokens in parse_token_tree.
145b847 
This sometimes avoids a lot of `bump` calls.
@nnethercote nnethercote force-pushed the parse_token_tree-speedup-for-uom branch from eba4cf2 to 145b847 Compare August 14, 2025 05:36
@nnethercote
Copy link
Contributor Author

nnethercote commented Aug 14, 2025

This was inspired by the uom crate:
Screenshot From 2025-08-14 15-53-48

@nnethercote nnethercote marked this pull request as ready for review August 14, 2025 05:55
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 14, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 14, 2025

📌 Commit 145b847 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
@bors
Copy link
Collaborator

bors commented Aug 20, 2025

⌛ Testing commit 145b847 with merge bec7474...

@bors
Copy link
Collaborator

bors commented Aug 20, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing bec7474 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 20, 2025
@bors bors merged commit bec7474 into rust-lang:master Aug 20, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 22a86f8 (parent) -> bec7474 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard bec747418c9955de4c3fd0aac4acb99206f00aa2 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 6323.3s -> 8506.4s (34.5%)
  2. dist-aarch64-linux: 8549.0s -> 6117.6s (-28.4%)
  3. pr-check-1: 1846.0s -> 1588.0s (-14.0%)
  4. dist-apple-various: 4341.1s -> 4910.7s (13.1%)
  5. x86_64-gnu-aux: 7289.2s -> 6498.2s (-10.9%)
  6. x86_64-gnu-tools: 3490.1s -> 3839.8s (10.0%)
  7. aarch64-gnu: 6990.5s -> 7442.9s (6.5%)
  8. dist-android: 2480.4s -> 2622.6s (5.7%)
  9. x86_64-gnu-stable: 7279.3s -> 7671.9s (5.4%)
  10. dist-powerpc-linux: 4947.1s -> 5175.1s (4.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Aug 20, 2025

Finished benchmarking commit (bec7474): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.0% [-2.1%, -0.3%] 16
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.6% [5.6%, 5.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.428s -> 471.629s (0.26%)
Artifact size: 378.15 MiB -> 378.28 MiB (0.03%)

@nnethercote nnethercote deleted the parse_token_tree-speedup-for-uom branch August 20, 2025 21:57
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge of rust-lang#145348 - nnethercote:parse_token_tree-speedup…
af0fd3b 
…-for-uom, r=petrochenkov

Sometimes skip over tokens in `parse_token_tree`.

r? `@petrochenkov`
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#145348 - nnethercote:parse_token_tree-speedup…
02e073f 
…-for-uom, r=petrochenkov

Sometimes skip over tokens in `parse_token_tree`.

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nnethercote @rust-timer @petrochenkov @bors @rustbot