Skip to content

Beta backport: null terminate UNICODE_STRINGs#143275

Merged
bors merged 1 commit intorust-lang:betafrom
ChrisDenton:beta-workaround
Jul 11, 2025
Merged

Beta backport: null terminate UNICODE_STRINGs#143275
bors merged 1 commit intorust-lang:betafrom
ChrisDenton:beta-workaround

Conversation

@ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Jul 1, 2025 •
edited
Loading

This is a beta backport of #143090 but, unlike that PR, it only does the minimum necessary. I think it would also be good to backport to stable but only if there's a stable release for another reason.

This will need a t-libs decision.

@ChrisDenton ChrisDenton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 1, 2025
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-android Operating system: Android O-linux Operating system: Linux O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 1, 2025
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2025
@ChrisDenton ChrisDenton changed the base branch from master to beta July 1, 2025 10:03
@ChrisDenton
Copy link
Member Author

ChrisDenton commented Jul 1, 2025

wait, I targeted the wrong branch... oops

@ChrisDenton ChrisDenton removed A-testsuite Area: The testsuite used to check the correctness of rustc O-linux Operating system: Linux O-android Operating system: Android T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. labels Jul 1, 2025
@Urgau Urgau mentioned this pull request Jul 1, 2025
Merged
Amanieu
Amanieu reviewed Jul 2, 2025
View reviewed changes
@Amanieu Amanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 2, 2025
@the8472 the8472 added the release-blog-post Marks issues tracking what text to put in the release blog post. label Jul 3, 2025
@Amanieu
Copy link
Member

Amanieu commented Jul 7, 2025

r? @cuviper

@rustbot rustbot assigned cuviper and unassigned Amanieu Jul 7, 2025
@cuviper cuviper mentioned this pull request Jul 10, 2025
Merged
@cuviper cuviper added this to the 1.89.0 milestone Jul 10, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 10, 2025
bors added a commit that referenced this pull request Jul 11, 2025
@bors
Auto merge of #143757 - cuviper:beta-next, r=cuviper
b123710 
[beta] backports

- Beta backport: null terminate UNICODE_STRINGs #143275
- Fix hang in --print=file-names in bootstrap #142928
- Reduce mismatched-lifetime-syntaxes suggestions to MaybeIncorrect #142980
- Update LLVM submodule #143126
- Do not unify borrowed locals in CopyProp. #143509
- Disable docs for `compiler-builtins` and `sysroot` #143660
- Update version placeholders in stdarch rust-lang/stdarch#1840

r? cuviper
@bors bors merged commit 8eb4554 into rust-lang:beta Jul 11, 2025
10 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@cuviper cuviper

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. O-windows Operating system: Windows release-blog-post Marks issues tracking what text to put in the release blog post. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.89.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ChrisDenton @rustbot @Amanieu @cuviper @the8472 @bors