install: Removed lib dir assumptions, closes #13810#14284
Closed
iliekturtles wants to merge 1 commit intorust-lang:masterfrom
Closed
install: Removed lib dir assumptions, closes #13810#14284iliekturtles wants to merge 1 commit intorust-lang:masterfrom
iliekturtles wants to merge 1 commit intorust-lang:masterfrom
Conversation
Replaced literal 'lib' with source relative lib directory. mingw32 uses 'bin' instead of 'lib'. Closes rust-lang#13810.
Contributor
|
I am not sure this is robust enough, If the invoker of Cc @brson |
Contributor
Author
|
I think you're right about that. And if |
Contributor
|
@iliekturtles Thanks for picking this issue up, and sorry I've been neglecting it. I've left my comments over there. Per those comments, I think this is indeed not a viable solution though, so closing. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Mar 13, 2023
fix: Highlight unresolved derives as being unresolved Fixes rust-lang/rust-analyzer#11350
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 15, 2025
Added lint for catching `&[foo.clone()]` where foo is a reference and suggests `std::slice::from_ref(foo)`. changelog: new lint: [`cloned_ref_to_slice_refs`]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that
CFG_LIBDIRandCFG_LIBDIR_RELATIVEare already exported somewhere by the timeinstall.shis run when doingmake install. Why aren'tCFG_MANDIRandCFG_MANDIR_RELATIVEexported? I'm guessing that none of these variables can be relied on for binary distribution situations? Is this why line 228 assumeslibif no--libdiroption is given?My solution relies on
CFG_PREFIXbeing the prefix toCFG_LIBDIRandCFG_MANDIRand that the relative portion of the path will match in both the source and destination. Is this a valid assumption?I tested
make installon both mingw32 and Linux. Are there any other targets I should run when making changes toinstall.sh?