Skip to content

Add modern AVR mcus like avr128db28 and attiny3224#142454

Merged
bors merged 2 commits intorust-lang:masterfrom
tomtor:avr-update
Jul 22, 2025
Merged

Add modern AVR mcus like avr128db28 and attiny3224#142454
bors merged 2 commits intorust-lang:masterfrom
tomtor:avr-update

Conversation

@tomtor
Copy link
Contributor

@tomtor tomtor commented Jun 13, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2025

Failed to set assignee to Patryk27: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 13, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@Patryk27
Copy link
Contributor

Patryk27 commented Jun 13, 2025

Looks good to me - we should wait for LLVM, though.

@tgross35
Copy link
Contributor

tgross35 commented Jun 18, 2025 •
edited
Loading

We need to wait for the LLVM change to make it into our LLVM right? Or, what is the behavior when these are used but LLVM doesn't yet support them?

@rustbot blocked
r? tgross35

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025
tgross35
tgross35 reviewed Jun 18, 2025
View reviewed changes
compiler/rustc_target/src/spec/base/avr.rs
Comment on lines +337 to +357
"avr64da28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64da32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64da48" => elf::EF_AVR_ARCH_XMEGA2,
"avr64da64" => elf::EF_AVR_ARCH_XMEGA2,
"avr64db28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64db32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64db48" => elf::EF_AVR_ARCH_XMEGA2,
"avr64db64" => elf::EF_AVR_ARCH_XMEGA2,
"avr64dd14" => elf::EF_AVR_ARCH_XMEGA2,
"avr64dd20" => elf::EF_AVR_ARCH_XMEGA2,
"avr64dd28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64dd32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64du28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64du32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64ea28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64ea32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64ea48" => elf::EF_AVR_ARCH_XMEGA2,
"avr64sd28" => elf::EF_AVR_ARCH_XMEGA2,
"avr64sd32" => elf::EF_AVR_ARCH_XMEGA2,
"avr64sd48" => elf::EF_AVR_ARCH_XMEGA2,

Copy link
Contributor

@tgross35 tgross35 Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style q, should this block be sorted in with avr16/avr32/avr128?

Copy link
Contributor Author

@tomtor tomtor Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style q, should this block be sorted in with avr16/avr32/avr128?

It is now in sync with the LLVM source order, so I prefer to not diverge from that.

Copy link
Contributor

@tgross35 tgross35 Jun 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it just looked a bit random :)

@tomtor
Copy link
Contributor Author

tomtor commented Jun 18, 2025 •
edited
Loading

We need to wait for the LLVM change to make it into our LLVM right? Or, what is the behavior when these are used but LLVM doesn't yet support them?

@rustbot blocked r? tgross35

@tgross35 The users get a:

'avr128db28' is not a recognized processor for this target (ignoring processor)

So there is no critical reason to wait, but waiting would allow easy and better testing of this PR, so I suggest to wait until the LLVM changes are visible in our default LLVM.

@Patryk27 Patryk27 mentioned this pull request Jul 13, 2025
Merged
@Patryk27
Copy link
Contributor

Patryk27 commented Jul 20, 2025

We could merge this now, since the related LLVM changes got pulled together with github.com//pull/143873 - cc @tgross35? 👀

@tgross35
Copy link
Contributor

tgross35 commented Jul 21, 2025

Great, thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

📌 Commit 1323fd6 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 21, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#142454 - tomtor:avr-update, r=tgross35
5290a8c 
Add modern AVR mcus like avr128db28 and attiny3224

Related to llvm/llvm-project#143914

r? `@Patryk27`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#142454 - tomtor:avr-update, r=tgross35
39446dd 
Add modern AVR mcus like avr128db28 and attiny3224

Related to llvm/llvm-project#143914

r? ``@Patryk27``
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Closed
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144286 - matthiaskrgr:rollup-1h1nn6b, r=matthiaskrgr
0d50eab 
Rollup of 8 pull requests

Successful merges:

 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #143906 (Miri: non-deterministic floating point operations in `foreign_items`)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 22, 2025
Merged
bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144294 - matthiaskrgr:rollup-ybvall3, r=matthiaskrgr
35487a2 
Rollup of 7 pull requests

Successful merges:

 - #142454 (Add modern AVR mcus like avr128db28 and attiny3224)
 - #142924 (tidy: move rustdoc js stuff into a tidy extra check)
 - #143373 (Unquerify maybe_unused_trait_imports.)
 - #144082 (tests: cover more `exported_private_dependencies` cases)
 - #144126 (Fix empty target_config in apply_rust_config bootstrap)
 - #144164 ( opt-dist: add an option for setting path to stage0 root)
 - #144265 (Dont ICE on copy error being suppressed due to overflow)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ed92e53 into rust-lang:master Jul 22, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 22, 2025
rust-timer added a commit that referenced this pull request Jul 22, 2025
@rust-timer
Unrolled build for #142454
e8d642e 
Rollup merge of #142454 - tomtor:avr-update, r=tgross35

Add modern AVR mcus like avr128db28 and attiny3224

Related to llvm/llvm-project#143914

r? ```@Patryk27```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.90.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tomtor @rustbot @Patryk27 @tgross35 @bors