speed up charsearcher for ascii chars by bend-n · Pull Request #141516 · rust-lang/rust

bend-n · 2025-05-24T19:02:23Z

attempt at fixing #82471

this implementation should be valid because ascii characters are always one byte and there are no continuation bytes that overlap with ascii characters

im not completely sure that this is always an improvement but it seems to be an improvement for this case and i dont think it can significantly regress any cases

workingjubilee · 2025-05-24T20:10:26Z

I do not expect changing this library API to significantly affect the speed of rustc compiling code, so I do not think a perf run is relevant.

bend-n · 2025-05-25T15:55:40Z

this takes the mentioned benchmark from

Time elapsed in splitn is: 2.04s
Time elapsed in iter() rposition is: 435.90ms

to

Time elapsed in splitn is: 425.42ms
Time elapsed in iter() rposition is: 454.41ms

rustbot · 2025-05-25T17:20:43Z

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

workingjubilee · 2025-05-25T18:28:50Z

awesome. easy win and much nicer code than the first version. squash?

workingjubilee · 2025-05-25T21:10:18Z

@bors r+

bors · 2025-05-25T21:10:20Z

📌 Commit 245bf50 has been approved by workingjubilee

It is now in the queue for this repository.

workingjubilee · 2025-05-25T21:10:23Z

Thanks!

Rollup of 10 pull requests Successful merges: - #140898 (minor improvements on running miri) - #141392 (Avoid obligation construction dance with query region constraints) - #141431 (Emit dummy open drop for unsafe binder) - #141433 (Properly analyze captures from unsafe binders) - #141439 (Deduplicate dyn compatibility violations due to coercion) - #141449 (further deduplicate ast visitor code) - #141513 (interpret: add allocation parameters to `AllocBytes`) - #141516 (speed up charsearcher for ascii chars) - #141526 (add a dedicated section for compiler environment variables in the unstable book) - #141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141516 - bend-n:okay, r=workingjubilee speed up charsearcher for ascii chars attempt at fixing #82471 this implementation should be valid because ascii characters are always one byte and there are no continuation bytes that overlap with ascii characters im not completely sure that this is _always_ an improvement but it seems to be an improvement for this case and i dont think it can significantly regress any cases

Rollup of 10 pull requests Successful merges: - rust-lang/rust#140898 (minor improvements on running miri) - rust-lang/rust#141392 (Avoid obligation construction dance with query region constraints) - rust-lang/rust#141431 (Emit dummy open drop for unsafe binder) - rust-lang/rust#141433 (Properly analyze captures from unsafe binders) - rust-lang/rust#141439 (Deduplicate dyn compatibility violations due to coercion) - rust-lang/rust#141449 (further deduplicate ast visitor code) - rust-lang/rust#141513 (interpret: add allocation parameters to `AllocBytes`) - rust-lang/rust#141516 (speed up charsearcher for ascii chars) - rust-lang/rust#141526 (add a dedicated section for compiler environment variables in the unstable book) - rust-lang/rust#141550 (Fix `unused_braces` lint suggestion when encountering attributes) r? `@ghost` `@rustbot` modify labels: rollup

speed up charsearcher for ascii chars attempt at fixing rust-lang#82471 this implementation should be valid because ascii characters are always one byte and there are no continuation bytes that overlap with ascii characters im not completely sure that this is _always_ an improvement but it seems to be an improvement for this case and i dont think it can significantly regress any cases

Revert "increase perf of charsearcher for single ascii characters" This reverts commit 245bf50 (PR #141516). It caused a large `doc` perf. regression in #141605.

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

Revert "increase perf of charsearcher for single ascii characters" This reverts commit 245bf503e2a948ac98170516d11df632e85a948b (PR rust-lang/rust#141516). It caused a large `doc` perf. regression in rust-lang/rust#141605.

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

Revert "increase perf of charsearcher for single ascii characters" This reverts commit 245bf50 (PR rust-lang#141516). It caused a large `doc` perf. regression in rust-lang#141605.

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

Revert "increase perf of charsearcher for single ascii characters" This reverts commit 245bf50 (PR rust-lang/rust#141516). It caused a large `doc` perf. regression in rust-lang/rust#141605.

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 24, 2025

This comment has been minimized.

Sign in to view

bend-n force-pushed the okay branch 3 times, most recently from ddd1892 to a356e45 Compare May 25, 2025 15:58

bend-n marked this pull request as ready for review May 25, 2025 17:20

rustbot assigned workingjubilee May 25, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2025

bend-n changed the title ~~an attempt~~ speed up charsearcher for ascii chars May 25, 2025

bend-n force-pushed the okay branch 4 times, most recently from 275e9dd to be63840 Compare May 25, 2025 18:39

increase perf of charsearcher for single ascii characters

245bf50

bend-n force-pushed the okay branch from be63840 to 245bf50 Compare May 25, 2025 18:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2025

jieyouxu mentioned this pull request May 26, 2025

Rollup of 10 pull requests #141605

Merged

bors merged commit 408dc51 into rust-lang:master May 26, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 26, 2025

bend-n deleted the okay branch May 27, 2025 03:33

Kobzol mentioned this pull request May 28, 2025

Revert "increase perf of charsearcher for single ascii characters" #141678

Merged

RalfJung mentioned this pull request May 29, 2025

str::splitn(N, ' ') is slower than it ought to be #82471

Closed

bend-n mentioned this pull request May 31, 2025

faster charsearcher #141808

Closed

rust-bors bot added a commit that referenced this pull request May 31, 2025

Auto merge of #141808 - bend-n:faster_charsearcher_take2_with_memchr,…

c0dc3e0

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

rust-bors bot added a commit that referenced this pull request Jun 2, 2025

Auto merge of #141808 - bend-n:faster_charsearcher_take2_with_memchr,…

ef13fec

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

rust-bors bot added a commit that referenced this pull request Jun 3, 2025

Auto merge of #141808 - bend-n:faster_charsearcher_take2_with_memchr,…

e5df514

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

rust-bors bot added a commit that referenced this pull request Jun 4, 2025

Auto merge of #141808 - bend-n:faster_charsearcher_take2_with_memchr,…

bd36a7c

… r=<try> faster charsearcher attempt to do #141516 better resolves #82471 r? `@workingjubilee`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

speed up charsearcher for ascii chars#141516

speed up charsearcher for ascii chars#141516
bors merged 1 commit intorust-lang:masterfrom
bend-n:okay

bend-n commented May 24, 2025 •

edited

Loading

Uh oh!

This comment has been minimized.

workingjubilee commented May 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

bend-n commented May 25, 2025

Uh oh!

rustbot commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

bend-n commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

workingjubilee commented May 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

bend-n commented May 25, 2025

Uh oh!

rustbot commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

bors commented May 25, 2025

Uh oh!

workingjubilee commented May 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bend-n commented May 24, 2025 •

edited

Loading