Skip to content

Update to LLVM 20.1.5#141063

Merged
bors merged 1 commit intorust-lang:masterfrom
dianqk:llvm-20.1.5
May 18, 2025
Merged

Update to LLVM 20.1.5#141063
bors merged 1 commit intorust-lang:masterfrom
dianqk:llvm-20.1.5

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented May 16, 2025

@rustbot label A-LLVM T-compiler

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@cuviper
Copy link
Member

cuviper commented May 16, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented May 16, 2025

📌 Commit c7a2694 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025
@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Testing commit c7a2694 with merge ae3b909...

@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing ae3b909 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 18, 2025
@bors bors merged commit ae3b909 into rust-lang:master May 18, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ac17c34 (parent) -> ae3b909 (this PR)

Test differences

Show 9 test diffs

Stage 2

  • [assembly] tests/assembly/riscv-soft-abi-with-float-features.rs#LLVM-PRE-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [assembly] tests/assembly/sanitizer/kcfi/emit-arity-indicator.rs#x86_64: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [assembly] tests/assembly/x86_64-bigint-helpers.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/integer-cmp.rs#llvm-pre-20: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J0)
  • [codegen] tests/codegen/issues/issue-101082.rs#x86-64-v3: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [codegen] tests/codegen/sanitizer/kcfi/add-kcfi-arity-flag.rs#x86_64: ignore (ignored when the LLVM version 20.1.4 is older than 21.0.0) -> ignore (ignored when the LLVM version 20.1.5 is older than 21.0.0) (J0)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-DEBUG: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J1)
  • [assembly] tests/assembly/x86_64-cmp.rs#LLVM-PRE-20-OPTIM: ignore (ignored when the LLVM version (20.1.4) is newer than majorversion 19) -> ignore (ignored when the LLVM version (20.1.5) is newer than majorversion 19) (J1)
  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J2)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ae3b909a323aa771db8ee3919c1454b77db05fbf --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 2553.7s -> 3986.9s (56.1%)
  2. mingw-check: 1292.5s -> 1811.3s (40.1%)
  3. armhf-gnu: 4454.1s -> 6148.3s (38.0%)
  4. test-various: 4116.1s -> 5648.0s (37.2%)
  5. arm-android: 5319.6s -> 7107.3s (33.6%)
  6. x86_64-gnu-stable: 6521.3s -> 8702.2s (33.4%)
  7. x86_64-gnu: 6344.3s -> 8363.9s (31.8%)
  8. x86_64-apple-2: 6498.9s -> 4556.2s (-29.9%)
  9. x86_64-gnu-aux: 6011.4s -> 7796.2s (29.7%)
  10. x86_64-gnu-nopt: 5608.2s -> 7261.3s (29.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@dianqk dianqk deleted the llvm-20.1.5 branch May 18, 2025 08:43
@rust-timer
Copy link
Collaborator

rust-timer commented May 18, 2025

Finished benchmarking commit (ae3b909): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.8% [0.7%, 1.0%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.8%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.8% [1.8%, 1.8%] 1
Regressions ❌
(secondary)		 1.2% [0.4%, 2.1%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.6% [-0.6%, -0.6%] 1
All ❌✅ (primary) 1.8% [1.8%, 1.8%] 1

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.4%, 2.5%] 7
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-1.0%, -0.4%] 4
All ❌✅ (primary) - - 0

Binary size

Results (secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Bootstrap: 777.472s -> 777.393s (-0.01%)
Artifact size: 365.48 MiB -> 365.45 MiB (-0.01%)

@nikic nikic added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 23, 2025
@nikic
Copy link
Contributor

nikic commented May 23, 2025

Nominating for beta because it fixes a large compile-time regression on s390x (#141287).

@jieyouxu jieyouxu mentioned this pull request May 23, 2025
Closed
@folkertdev folkertdev mentioned this pull request May 27, 2025
Closed
@dianqk
Copy link
Member Author

dianqk commented May 29, 2025 •
edited
Loading

Nominating for beta because it fixes a large compile-time regression on s390x (#141287).

LLVM 20.1.4 that has landed in beta has fixed this issue. Keep the label, we can double-check later.

@dianqk
Copy link
Member Author

dianqk commented May 29, 2025

Diff: rust-lang/llvm-project@8448283...c1118fd.

There are some fixes for x86 and aarch64.

@apiraino
Copy link
Contributor

apiraino commented May 29, 2025

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 29, 2025
@cuviper cuviper mentioned this pull request May 29, 2025
Merged
@cuviper cuviper modified the milestones: 1.89.0, 1.88.0 May 29, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 29, 2025
bors added a commit that referenced this pull request Jun 1, 2025
@bors
Auto merge of #141745 - cuviper:beta-next, r=cuviper
f6d9f5e 
[beta] backports

- Update to LLVM 20.1.5 #141063

r? cuviper
bors added a commit that referenced this pull request Jun 1, 2025
@bors
Auto merge of #141745 - cuviper:beta-next, r=cuviper
645b44e 
[beta] backports

- Update to LLVM 20.1.5 #141063

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.88.0

Development

Successfully merging this pull request may close these issues.

7 participants

@dianqk @rustbot @cuviper @bors @rust-timer @nikic @apiraino