Move the mutex module out of std::unstable and straight into libstd.#14011
Move the mutex module out of std::unstable and straight into libstd.#14011thehydroimpulse wants to merge 1 commit intorust-lang:masterfrom
Conversation
|
This is a bit of a special case in that I'm wary about providing a I think what with the std facade this will end up finding its own place, but for now it may want to continue to live in |
|
I think we should continue moving things out of |
|
If we must move it, let's please add it to |
|
Maybe something like |
|
Ahh, that's right. I forgot it's not the public mutex. |
|
Let's not start with |
|
Ok, I'll move it to |
|
I think it's fine to move it out of |
|
@alexcrichton Moved it to rt and added a proper commit message. |
|
Could you expand a bit on the rationale for why this module is moving? It's useful to put it directly in the commit message rather than indirectly through some links. |
|
@alexcrichton Done. |
|
(needs a rebase) Could you also put a newline before "This is to cleanout..." |
|
@alexcrichton Done. |
|
Oops, didn't see that this failed. I'll get this fixed. |
|
@alexcrichton Fixed the failing build. Tests pass on my end. |
|
Needs another rebase. |
|
@huonw Sorry, didn't get a notification on this PR. Rebased. |
This is to cleanout the std::unstable module and use the appropriate unstable attribute. This mutex module is **not** supposed to be used outside of the compiler/std. This change is according to rust-lang#1457 and comment rust-lang#1457 (comment) [breaking-change]
There was a problem hiding this comment.
This was probably unintentional
…ievink fix(ide-assists): unwrap block when it parent is let stmt fix rust-lang#13990
Counting in bytes for a pointer to `u8` is legitimate and must not
trigger the lint. Also, this prevents linting the
`{std,core}::ptr::write_bytes` as it manipulates bytes.
Fix rust-lang#6590
changelog: [`size_of_in_element_count`]: do not lint if the pointee type
is `u8`
This is not a breaking change as mutex is re-exported in std::unstable
to make a transition easier.
std::mutexis also marked as unstable.This change is related to #1457 and comment
#1457 (comment)