RFC: linker placement attribute proposed implementation#13661
Closed
farcaller wants to merge 2 commits intorust-lang:masterfrom
Closed
RFC: linker placement attribute proposed implementation#13661farcaller wants to merge 2 commits intorust-lang:masterfrom
farcaller wants to merge 2 commits intorust-lang:masterfrom
Conversation
added 2 commits
April 21, 2014 17:49
#[unsafe_override_address] static t: T = 123 would be pointing to ((*T)123). The global is not registered in this case.
Member
|
Thank you for the reference implementation! Following our RFC protocol, however, it's not quite yet time for a PR to open up on the rust repo:
Closing for now, but this is cc'd on the RFC, so it should stick around. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2023
…et, r=jonas-schievink Fix: Handle empty `checkOnSave/target` values This fixes a regression introduced by rust-lang#13290, in which failing to set `checkOnSave/target` (or `checkOnSave/targets`) would lead to an invalid config. [Fixes rust-lang#13660]
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 7, 2024
Link fix [`clippy::await_holding_lock`](https://rust-lang.github.io/rust-clippy/master/index.html#/await_holding_lock) has unformatted link changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation of feature in rust-lang/rfcs#44, it allows to use the following code:
that will create a t pointing to 123 address in memory.
I also have an alternative implementation that uses
&'static Tand requires less patching, not sure which one is better.