Update iterator.rs to use arrays by value#136183
Merged
bors merged 1 commit intorust-lang:masterfrom May 6, 2025
Merged
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Amanieu
reviewed
May 3, 2025
| /// | ||
| /// let d2 = d3.iter().flatten().collect::<Vec<_>>(); | ||
| /// assert_eq!(d2, [&[1, 2], &[3, 4], &[5, 6], &[7, 8]]); | ||
| /// let d2: Vec<_> = d3.clone().into_iter().flatten().collect(); |
Member
There was a problem hiding this comment.
I don't think this is reasonable here: we don't want to encourage .clone().into_iter() when .iter() is sufficient.
Member
Author
There was a problem hiding this comment.
Hmm, that is a good point. I'll have a look.
Member
Author
There was a problem hiding this comment.
Apparently the .clone() is (now?) unnecessary.
Update examples to no longer avoid iterating arrays for rust-lang#84513
dce0f52 to
18a3599
Compare
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#136183 (Update iterator.rs to use arrays by value) - rust-lang#139966 (coverage: Only merge adjacent coverage spans) - rust-lang#140692 (Rename `graph::implementation::Graph` to `LinkedGraph`) - rust-lang#140703 (Handle PR not found in post-merge workflow) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
Rollup merge of rust-lang#136183 - hkBst:patch-25, r=Amanieu Update iterator.rs to use arrays by value Update examples to no longer avoid iterating arrays for rust-lang#84513
github-actions bot
pushed a commit
to carolynzech/rust
that referenced
this pull request
May 16, 2025
Update iterator.rs to use arrays by value Update examples to no longer avoid iterating arrays for rust-lang#84513
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update examples to no longer avoid iterating arrays for #84513