Merge the intrinsic and user tests for select_unpredictable#135112
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 6, 2025
Merged
Merge the intrinsic and user tests for select_unpredictable#135112bors merged 2 commits intorust-lang:masterfrom
select_unpredictable#135112bors merged 2 commits intorust-lang:masterfrom
Conversation
[1] mentions that having a single test with `-Zmerge-functions=disabled` is preferable to having two separate tests. Apply that to the new `select_unpredicatble` test here. [1]: rust-lang#133964 (comment)
the8472
approved these changes
Jan 5, 2025
Member
the8472
left a comment
There was a problem hiding this comment.
The change itself is fine, but one of the existing tests looks strange
Comment on lines
+65
to
+66
| // CHECK-LABEL: define{{.*}} @test_zst2 | ||
| p.select_unpredictable(a, b) |
Member
There was a problem hiding this comment.
this doesn't seem to test anything, just that the function exists, not what it does.
Contributor
Author
There was a problem hiding this comment.
I assume this was just intended to verify that no select is emitted, so I added a commit to assert the function body is empty.
For ZSTs there is no selection that needs to take place, so assert that no `select` statement is emitted.
c36a09c to
74d2d4b
Compare
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2025
…e-test, r=the8472 Merge the intrinsic and user tests for `select_unpredictable` [1] mentions that having a single test with `-Zmerge-functions=disabled` is preferable to having two separate tests. Apply that to the new `select_unpredictable` test here. [1]: rust-lang#133964 (comment)
Collaborator
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
@bors retry |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (243d2ca): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.9%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -4.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 764.087s -> 763.649s (-0.06%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 mentions that having a single test with
-Zmerge-functions=disabledis preferable to having two separate tests. Apply that to the newselect_unpredictabletest here.r? @the8472