Use the unsigned integer types for bitwise intrinsics.#13506
Closed
huonw wants to merge 1 commit intorust-lang:masterfrom
Closed
Use the unsigned integer types for bitwise intrinsics.#13506huonw wants to merge 1 commit intorust-lang:masterfrom
huonw wants to merge 1 commit intorust-lang:masterfrom
Conversation
src/libstd/intrinsics.rs
Outdated
Contributor
There was a problem hiding this comment.
nit: Could you add NOTE here to make this pop-up in make tidy ?
I use to grep for stage0 when doing a snapshot but it's still useful to use NOTE and make tidy
Member
|
r=me, but it appears that there are failing tests on travis |
Exposing ctpop, ctlz, cttz and bswap as taking signed i8/i16/... is just exposing the internal LLVM names pointlessly (LLVM doesn't have "signed integers" or "unsigned integers", it just has sized integer types with (un)signed *operations*). These operations are semantically working with raw bytes, which the unsigned types model better.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 16, 2014
Closes rust-lang#13546 (workcache: Don't assume gcc exists on all platforms) Closes rust-lang#13545 (std: Remove pub use globs) Closes rust-lang#13530 (test: Un-ignore smallest-hello-world.rs) Closes rust-lang#13529 (std: Un-ignore some float tests on windows) Closes rust-lang#13528 (green: Add a helper macro for booting libgreen) Closes rust-lang#13526 (Remove RUST_LOG="::help" from the docs) Closes rust-lang#13524 (dist: Make Windows installer uninstall first. Closes rust-lang#9563) Closes rust-lang#13521 (Change AUTHORS section in the man pages) Closes rust-lang#13519 (Update GitHub's Rust projects page.) Closes rust-lang#13518 (mk: Change windows to install from stage2) Closes rust-lang#13516 (liburl doc: insert missing hyphen) Closes rust-lang#13514 (rustdoc: Better sorting criteria for searching.) Closes rust-lang#13512 (native: Fix a race in select()) Closes rust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.) Closes rust-lang#13502 (Add a default impl for Set::is_superset)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
…rednet unused_result_ok: added in Clippy 1.82.0, not 1.70.0 changelog: none Fix rust-lang#13497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the unsigned integer types for bitwise intrinsics.
Exposing ctpop, ctlz, cttz and bswap as taking signed i8/i16/... is just
exposing the internal LLVM names pointlessly (LLVM doesn't have "signed
integers" or "unsigned integers", it just has sized integer types
with (un)signed operations).
These operations are semantically working with raw bytes, which the
unsigned types model better.