Make sure we check the future type is Sized in AsyncFn*#134933
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 31, 2024
Merged
Make sure we check the future type is Sized in AsyncFn*#134933bors merged 1 commit intorust-lang:masterfrom
Sized in AsyncFn*#134933bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
compiler-errors
commented
Dec 30, 2024
Member
|
could the mcve from the issue be added as a test? |
Contributor
Author
|
Ya i just forgot to stage and commit it lol |
lqd
approved these changes
Dec 30, 2024
Member
lqd
left a comment
There was a problem hiding this comment.
r=me with the test, and with the comment if possible (but fine without it)
6aa29ae to
ed9a4cf
Compare
Contributor
Author
|
@bors r=lqd rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#134919 (bootstrap: Make `./x test compiler` actually run the compiler unit tests) - rust-lang#134927 (Make slice::as_flattened_mut unstably const) - rust-lang#134930 (ptr docs: make it clear that we are talking only about memory accesses) - rust-lang#134932 (explicitly set float ABI for all ARM targets) - rust-lang#134933 (Make sure we check the future type is `Sized` in `AsyncFn*`) - rust-lang#134934 (Fix typos) - rust-lang#134941 (compiler: Add a statement-of-intent to `rustc_abi`) - rust-lang#134949 (Convert some `Into` impls into `From` impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 31, 2024
Rollup merge of rust-lang#134933 - compiler-errors:async-fn-future-sized, r=lqd Make sure we check the future type is `Sized` in `AsyncFn*` Fixes rust-lang#134817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134817