Filter out builtin lint passes that don't need to be run by compiler-errors · Pull Request #134862 · rust-lang/rust

compiler-errors · 2024-12-28T21:43:07Z

r? @ghost

compiler-errors · 2024-12-28T21:43:25Z

@bors try @rust-timer queue

…dont-need-to-run, r=<try> Filter out builtin lint passes that don't need to be run r? `@ghost`

bors · 2024-12-28T21:44:36Z

⌛ Trying commit 7d164e8 with merge 13c9a98...

bors · 2024-12-28T23:33:34Z

☀️ Try build successful - checks-actions
Build commit: 13c9a98 (13c9a9898d3115935f66e16083b88e242805c131)

rust-timer · 2024-12-29T00:50:25Z

Finished benchmarking commit (13c9a98): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.3%, 3.3%]	79
Regressions ❌ (secondary)	2.5%	[0.1%, 7.8%]	75
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	18
Improvements ✅ (secondary)	-0.4%	[-0.8%, -0.2%]	12
All ❌✅ (primary)	0.9%	[-0.4%, 3.3%]	97

Max RSS (memory usage)

Results (primary -1.1%, secondary -2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-1.1%	[-2.0%, -0.5%]	11
Improvements ✅ (secondary)	-2.8%	[-3.9%, -2.1%]	5
All ❌✅ (primary)	-1.1%	[-2.0%, -0.5%]	11

Cycles

Results (primary 2.1%, secondary 5.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.1%, 5.4%]	48
Regressions ❌ (secondary)	5.8%	[2.2%, 15.0%]	54
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[1.1%, 5.4%]	48

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.432s -> 763.259s (0.11%)
Artifact size: 325.44 MiB -> 325.38 MiB (-0.02%)

compiler-errors · 2024-12-29T04:08:41Z

@bors try @rust-timer queue

…dont-need-to-run, r=<try> Filter out builtin lint passes that don't need to be run r? `@ghost`

bors · 2024-12-29T04:09:52Z

⌛ Trying commit e4b3df9 with merge 756bbec...

bors · 2024-12-29T05:57:37Z

☀️ Try build successful - checks-actions
Build commit: 756bbec (756bbecaae8695f8d7c42a9eb85ab34a9de3fffd)

rust-timer · 2024-12-29T08:12:10Z

Finished benchmarking commit (756bbec): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	7
Regressions ❌ (secondary)	0.3%	[0.2%, 0.6%]	12
Improvements ✅ (primary)	-0.6%	[-1.5%, -0.1%]	84
Improvements ✅ (secondary)	-0.9%	[-2.4%, -0.2%]	65
All ❌✅ (primary)	-0.5%	[-1.5%, 0.4%]	91

Max RSS (memory usage)

Results (primary -0.2%, secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.1%, 2.5%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.0%	[-1.9%, -0.5%]	6
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.0%]	2
All ❌✅ (primary)	-0.2%	[-1.9%, 2.5%]	8

Cycles

Results (primary -1.7%, secondary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-2.7%, -1.0%]	4
Improvements ✅ (secondary)	-2.9%	[-4.4%, -1.9%]	14
All ❌✅ (primary)	-1.7%	[-2.7%, -1.0%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 763.48s -> 762.172s (-0.17%)
Artifact size: 325.50 MiB -> 325.40 MiB (-0.03%)

compiler-errors · 2025-01-27T22:06:40Z

@bors try @rust-timer queue

…dont-need-to-run, r=<try> Filter out builtin lint passes that don't need to be run r? `@ghost`

bors · 2025-01-27T22:07:54Z

⌛ Trying commit 21c2cf4 with merge ae29230...

rust-log-analyzer · 2025-01-27T22:21:47Z

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
   Compiling rustc_codegen_ssa v0.0.0 (/checkout/compiler/rustc_codegen_ssa)
error[E0433]: failed to resolve: could not find `BitSet` in `bit_set`
   --> compiler/rustc_lint/src/passes.rs:117:64
    |
7   | /  macro_rules! late_lint_methods {
8   | |      ($macro:path, $args:tt) => (
9   | |          $macro!($args, [
    | | ________________-
10  | ||             fn check_body(a: &rustc_hir::Body<'tcx>);
11  | ||             fn check_body_post(a: &rustc_hir::Body<'tcx>);
...   ||
...   ||
47  | ||             fn check_attributes_post(a: &'tcx [rustc_hir::Attribute]);
    | ||__________- in this macro invocation (#2)
49  | |      )
50  | |  }
    | |__- in this expansion of `late_lint_methods!` (#1)
    | |__- in this expansion of `late_lint_methods!` (#1)
...
101 |  / macro_rules! declare_combined_late_lint_pass {
102 |  |     ([$v:vis $name:ident, [$($pass:ident: $constructor:expr,)*]], $methods:tt) => (
103 |  |         #[repr(u8)]
104 |  |         enum EnabledPasses {
...    |
117 |  |                 let mut enabled_passes = rustc_index::bit_set::BitSet::new_filled(${count($pass)});
    |  |                                                                ^^^^^^ could not find `BitSet` in `bit_set`
158 |  | }
    |  |_- in this expansion of `declare_combined_late_lint_pass!` (#2)
    |
   ::: compiler/rustc_lint/src/lib.rs:190:1
---

error[E0412]: cannot find type `BitSet` in module `rustc_index::bit_set`
   --> compiler/rustc_lint/src/passes.rs:110:51
    |
7   | /  macro_rules! late_lint_methods {
8   | |      ($macro:path, $args:tt) => (
9   | |          $macro!($args, [
    | | ________________-
10  | ||             fn check_body(a: &rustc_hir::Body<'tcx>);
11  | ||             fn check_body_post(a: &rustc_hir::Body<'tcx>);
...   ||
...   ||
47  | ||             fn check_attributes_post(a: &'tcx [rustc_hir::Attribute]);
    | ||__________- in this macro invocation (#2)
49  | |      )
50  | |  }
    | |__- in this expansion of `late_lint_methods!` (#1)
    | |__- in this expansion of `late_lint_methods!` (#1)
...
101 |  / macro_rules! declare_combined_late_lint_pass {
102 |  |     ([$v:vis $name:ident, [$($pass:ident: $constructor:expr,)*]], $methods:tt) => (
103 |  |         #[repr(u8)]
104 |  |         enum EnabledPasses {
...    |
110 |  |             enabled_passes: rustc_index::bit_set::BitSet<u8>,
    |  |                                                   ^^^^^^ not found in `rustc_index::bit_set`
158 |  | }
    |  |_- in this expansion of `declare_combined_late_lint_pass!` (#2)
    |
   ::: compiler/rustc_lint/src/lib.rs:190:1
---
Caused by:
    Command RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --rust-profile-generate /tmp/tmp-multistage/opt-artifacts/rustc-pgo --set llvm.thin-lto=false --set llvm.link-shared=true [at /checkout/obj] has failed with exit code Some(1)

Stack backtrace:
   0: <anyhow::Error>::msg::<alloc::string::String>
             at /rust/deps/anyhow-1.0.95/src/backtrace.rs:27:14
   1: <opt_dist::exec::CmdBuilder>::run
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/exec.rs:80:17
   2: <opt_dist::exec::Bootstrap>::run
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/exec.rs:181:9
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:238:13
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:238:13
   4: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}::{closure#0}, ()>
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/timer.rs:111:22
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:227:9
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:227:9
   6: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#1}, opt_dist::training::RustcPGOProfile>
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/timer.rs:111:22
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:224:29
   8: opt_dist::main
             at /rustc/ae29230abcc4a999967e71548cb1b9845d622385/src/tools/opt-dist/src/main.rs:415:18
   9: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
   9: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/core/src/ops/function.rs:250:5
  10: std::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/std/src/sys/backtrace.rs:152:18
  11: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/std/src/rt.rs:195:18
  12: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/core/src/ops/function.rs:284:13
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/std/src/panicking.rs:584:40
  14: std::panicking::try
             at /rustc/e30eefff41038ceea427009023627d6d66b36715/library/std/src/panicking.rs:547:19
  15: std::panic::catch_unwind

compiler-errors · 2025-01-27T22:26:13Z

@bors try @rust-timer queue

…dont-need-to-run, r=<try> Filter out builtin lint passes that don't need to be run r? `@ghost`

bors · 2025-01-27T22:27:25Z

⌛ Trying commit c49feda with merge 3e75b77...

rust-log-analyzer · 2025-01-27T23:09:22Z

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#21 exporting to docker image format
#21 sending tarball 27.5s done
#21 DONE 33.4s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
  Downloaded boml v0.3.1
   Compiling boml v0.3.1
   Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
    Finished `release` profile [optimized] target(s) in 3.97s
     Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc
---
---- [ui] tests/ui/print_type_sizes/multiple_types.rs stdout ----
Saved the actual stdout to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/multiple_types/multiple_types.stdout"
diff of stdout:

- print-type-size type: `Enum`: 51 bytes, alignment: 1 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `Large`: 50 bytes
- print-type-size         field `.0`: 50 bytes
- print-type-size     variant `Small`: 7 bytes
- print-type-size         field `.0`: 7 bytes
- print-type-size type: `FiftyBytes`: 50 bytes, alignment: 1 bytes
- print-type-size     field `.0`: 50 bytes
- print-type-size type: `SevenBytes`: 7 bytes, alignment: 1 bytes
- print-type-size     field `.0`: 7 bytes


The actual stdout differed from the expected stdout.
To update references, rerun the tests and pass the `--bless` flag
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args print_type_sizes/multiple_types.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/print_type_sizes/multiple_types.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/multiple_types" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Z" "print-type-sizes" "--crate-type=lib"
stderr: none


---- [ui] tests/ui/print_type_sizes/padding.rs stdout ----
---- [ui] tests/ui/print_type_sizes/padding.rs stdout ----
Saved the actual stdout to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/padding/padding.stdout"
diff of stdout:

- print-type-size type: `E1`: 12 bytes, alignment: 4 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `B`: 11 bytes
- print-type-size         padding: 3 bytes
- print-type-size         field `.0`: 8 bytes, alignment: 4 bytes
- print-type-size     variant `A`: 7 bytes
- print-type-size         field `.1`: 1 bytes
- print-type-size         padding: 2 bytes
- print-type-size         field `.0`: 4 bytes, alignment: 4 bytes
- print-type-size type: `E2`: 12 bytes, alignment: 4 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `B`: 11 bytes
- print-type-size         padding: 3 bytes
- print-type-size         field `.0`: 8 bytes, alignment: 4 bytes
- print-type-size     variant `A`: 7 bytes
- print-type-size         field `.0`: 1 bytes
- print-type-size         padding: 2 bytes
- print-type-size         field `.1`: 4 bytes, alignment: 4 bytes
- print-type-size type: `S`: 8 bytes, alignment: 4 bytes
- print-type-size     field `.g`: 4 bytes
- print-type-size     field `.a`: 1 bytes
- print-type-size     field `.b`: 1 bytes
- 


The actual stdout differed from the expected stdout.
The actual stdout differed from the expected stdout.
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args print_type_sizes/padding.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/print_type_sizes/padding.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/padding" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Z" "print-type-sizes" "--crate-type=lib"
stderr: none


---- [ui] tests/ui/print_type_sizes/repr_int_c.rs stdout ----
---- [ui] tests/ui/print_type_sizes/repr_int_c.rs stdout ----
Saved the actual stdout to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/repr_int_c/repr_int_c.stdout"
diff of stdout:

- print-type-size type: `ReprCu8`: 4 bytes, alignment: 2 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `A`: 3 bytes
- print-type-size         padding: 1 bytes
- print-type-size         field `.0`: 2 bytes, alignment: 2 bytes
- print-type-size     variant `B`: 1 bytes
- print-type-size type: `Repru8`: 4 bytes, alignment: 2 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `A`: 3 bytes
- print-type-size         padding: 1 bytes
- print-type-size         field `.0`: 2 bytes, alignment: 2 bytes
- print-type-size     variant `B`: 0 bytes


The actual stdout differed from the expected stdout.
To update references, rerun the tests and pass the `--bless` flag
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args print_type_sizes/repr_int_c.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/print_type_sizes/repr_int_c.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/repr_int_c" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Z" "print-type-sizes" "--crate-type=lib"
stderr: none


---- [ui] tests/ui/print_type_sizes/variants.rs stdout ----
---- [ui] tests/ui/print_type_sizes/variants.rs stdout ----
Saved the actual stdout to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/variants/variants.stdout"
diff of stdout:

- print-type-size type: `Enum`: 51 bytes, alignment: 1 bytes
- print-type-size     discriminant: 1 bytes
- print-type-size     variant `Large`: 50 bytes
- print-type-size         field `.0`: 50 bytes
- print-type-size     variant `Small`: 7 bytes
- print-type-size         field `.0`: 7 bytes
- print-type-size type: `FiftyBytes`: 50 bytes, alignment: 1 bytes
- print-type-size     field `.0`: 50 bytes
- print-type-size type: `SevenBytes`: 7 bytes, alignment: 1 bytes
- print-type-size     field `.0`: 7 bytes


The actual stdout differed from the expected stdout.
To update references, rerun the tests and pass the `--bless` flag
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args print_type_sizes/variants.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/print_type_sizes/variants.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/variants" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-Z" "print-type-sizes" "--crate-type=lib"
stderr: none

bors · 2025-01-28T00:14:37Z

☀️ Try build successful - checks-actions
Build commit: 3e75b77 (3e75b77a7bf804a4ea9c4011b46e1d67b6bbfaa3)

rust-timer · 2025-01-28T01:53:32Z

Finished benchmarking commit (3e75b77): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.2%]	67
Regressions ❌ (secondary)	1.3%	[0.3%, 3.0%]	53
Improvements ✅ (primary)	-0.4%	[-1.0%, -0.2%]	22
Improvements ✅ (secondary)	-0.8%	[-2.0%, -0.2%]	33
All ❌✅ (primary)	0.2%	[-1.0%, 1.2%]	89

Max RSS (memory usage)

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.7%, 1.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.4%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-1.3%, 1.0%]	12

Cycles

Results (primary -1.4%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	7.9%	[6.7%, 9.1%]	6
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-3.3%	[-4.0%, -2.6%]	6
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.391s -> 773.075s (-0.17%)
Artifact size: 328.16 MiB -> 328.10 MiB (-0.02%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 28, 2024