compiler: Set target_abi = "ilp32e" on all riscv32e targets#134358
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 26, 2025
Merged
compiler: Set target_abi = "ilp32e" on all riscv32e targets#134358bors merged 1 commit intorust-lang:masterfrom
target_abi = "ilp32e" on all riscv32e targets#134358bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
Collaborator
|
These commits modify compiler targets. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
oh right, okay I guess. |
This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets.
0eff783 to
9a81dc9
Compare
Member
Author
|
hey, Embedded RISCV Team? Can you sign off on this and maybe also adopt these rv32e targets? @almindor @dkhayes117 @romancardenas @MabezDev @jessebraham @rmsyn |
MabezDev
approved these changes
Jan 24, 2025
Contributor
MabezDev
left a comment
There was a problem hiding this comment.
LGTM
I don't speak for the whole team, but I think we should be fine to maintain these along with the targets we already do.
almindor
approved these changes
Jan 24, 2025
rmsyn
approved these changes
Jan 25, 2025
|
LGTM, too. Same as @MabezDev, I only speak for myself, but I bought a dev board specifically to help test |
romancardenas
approved these changes
Jan 25, 2025
fmease
approved these changes
Jan 25, 2025
Member
|
Thanks all! @bors r+ rollup |
Collaborator
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jan 26, 2025
…abi, r=fmease compiler: Set `target_abi = "ilp32e"` on all riscv32e targets This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2025
Rollup of 8 pull requests Successful merges: - rust-lang#133631 (Support QNX 7.1 with `io-sock`+libstd and QNX 8.0 (`no_std` only)) - rust-lang#134358 (compiler: Set `target_abi = "ilp32e"` on all riscv32e targets) - rust-lang#135764 (Fix tests on LLVM 20) - rust-lang#135812 (Fix GDB `OsString` provider on Windows ) - rust-lang#135842 (TRPL: more backward-compatible Edition changes) - rust-lang#135946 (Remove extra whitespace from rustdoc breadcrumbs for copypasting) - rust-lang#135953 (ci.py: check the return code in `run-local`) - rust-lang#136019 (Add an `unchecked_div` alias to the `Div<NonZero<_>>` impls) Failed merges: - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#133631 (Support QNX 7.1 with `io-sock`+libstd and QNX 8.0 (`no_std` only)) - rust-lang#134358 (compiler: Set `target_abi = "ilp32e"` on all riscv32e targets) - rust-lang#135812 (Fix GDB `OsString` provider on Windows ) - rust-lang#135842 (TRPL: more backward-compatible Edition changes) - rust-lang#135946 (Remove extra whitespace from rustdoc breadcrumbs for copypasting) - rust-lang#135953 (ci.py: check the return code in `run-local`) - rust-lang#136019 (Add an `unchecked_div` alias to the `Div<NonZero<_>>` impls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2025
Rollup merge of rust-lang#134358 - workingjubilee:configure-my-riscv-abi, r=fmease compiler: Set `target_abi = "ilp32e"` on all riscv32e targets This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Rollup of 7 pull requests Successful merges: - rust-lang#133631 (Support QNX 7.1 with `io-sock`+libstd and QNX 8.0 (`no_std` only)) - rust-lang#134358 (compiler: Set `target_abi = "ilp32e"` on all riscv32e targets) - rust-lang#135812 (Fix GDB `OsString` provider on Windows ) - rust-lang#135842 (TRPL: more backward-compatible Edition changes) - rust-lang#135946 (Remove extra whitespace from rustdoc breadcrumbs for copypasting) - rust-lang#135953 (ci.py: check the return code in `run-local`) - rust-lang#136019 (Add an `unchecked_div` alias to the `Div<NonZero<_>>` impls) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows compile-time configuration based on this. In the near future we should do this across all RISCV targets, probably, but this cfg is essential for building software usable on these targets, and they are tier 3 so it seems less of a concern to tweak their definition thusly.
cc @hegza
Effectively requested by @rmsyn in this Zulip thread: https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/riscv.20base.20ISA.20specifiers.20for.20conditional.20compilation/near/483836652