wasm(32|64): update alignment string#134165
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 11, 2024
Merged
Conversation
Collaborator
Collaborator
|
These commits modify compiler targets. |
Contributor
Author
|
@rustbot label: +llvm-main |
Member
|
LLVM PR for backlink: llvm/llvm-project#119204 |
jieyouxu
approved these changes
Dec 11, 2024
Member
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, one comment issue then r=me after PR CI is green.
This comment has been minimized.
This comment has been minimized.
c4d6ef3 to
0931a72
Compare
Member
|
@durin42 can you also update the PR title and reflection, since we also now modify wasm64 targets? |
Contributor
Author
I'm not sure what you mean by reflection, but I updated the PR title |
Member
I managed to type "reflection" when I meant "description", lol. Thanks! |
See llvm/llvm-project@c5ab70c @rustbot label: +llvm-main
0931a72 to
48b8832
Compare
Contributor
Author
|
force-pushed an updated log message |
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132975 (De-duplicate and improve definition of core::ffi::c_char) - rust-lang#133598 (Change `GetManyMutError` to match T-libs-api decision) - rust-lang#134148 (add comments in check_expr_field) - rust-lang#134163 (coverage: Rearrange the code for embedding per-function coverage metadata) - rust-lang#134165 (wasm(32|64): update alignment string) - rust-lang#134170 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2024
Rollup merge of rust-lang#134165 - durin42:wasm-target-string, r=jieyouxu wasm(32|64): update alignment string See llvm/llvm-project@c5ab70c `@rustbot` label: +llvm-main
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#132975 (De-duplicate and improve definition of core::ffi::c_char) - rust-lang#133598 (Change `GetManyMutError` to match T-libs-api decision) - rust-lang#134148 (add comments in check_expr_field) - rust-lang#134163 (coverage: Rearrange the code for embedding per-function coverage metadata) - rust-lang#134165 (wasm(32|64): update alignment string) - rust-lang#134170 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project@c5ab70c
@rustbot label: +llvm-main