Skip to content

Warn about invalid mir-enable-passes pass names#132901

Merged
bors merged 4 commits intorust-lang:masterfrom
clubby789:enable-pass-check
Nov 12, 2024
Merged

Warn about invalid mir-enable-passes pass names#132901
bors merged 4 commits intorust-lang:masterfrom
clubby789:enable-pass-check

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Nov 11, 2024

Fixes #132805

@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2024

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 11, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2024

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2024
jieyouxu
jieyouxu reviewed Nov 11, 2024
View reviewed changes
@clubby789
Copy link
Contributor Author

clubby789 commented Nov 11, 2024

Ah, looks like there's an issue with this approach - run_passes_inner is called in several places, with different lists of passes. There's currently no centralized list of pass names

@jieyouxu jieyouxu self-assigned this Nov 11, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789 clubby789 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@compiler-errors compiler-errors removed their assignment Nov 11, 2024
@clubby789
Copy link
Contributor Author

clubby789 commented Nov 11, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 11, 2024
clubby789
clubby789 commented Nov 11, 2024
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789 clubby789 closed this Nov 11, 2024
@clubby789 clubby789 reopened this Nov 11, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should be quite a nice cli UX improvement for people working on MIR opts and people doing bisection/debugging. One tiny nit then r=me.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 12, 2024

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2024
@clubby789
Copy link
Contributor Author

clubby789 commented Nov 12, 2024

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Nov 12, 2024

📌 Commit 8c64e9d has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
@bors
Auto merge of rust-lang#132954 - matthiaskrgr:rollup-x3rww9h, r=matth…
f7273e0 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#131831 (extend the "if-unchanged" logic for compiler builds)
 - rust-lang#132541 (Proper support for cross-crate recursive const stability checks)
 - rust-lang#132657 (AIX: add run-make support)
 - rust-lang#132901 (Warn about invalid `mir-enable-passes` pass names)
 - rust-lang#132923 (Triagebot: Consolidate the T-compiler ad hoc assignment groups)
 - rust-lang#132938 (Make precise capturing suggestion machine-applicable only if it has no APITs)
 - rust-lang#132947 (clarify `must_produce_diag` ICE for debugging)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8628fd5 into rust-lang:master Nov 12, 2024
@rustbot rustbot added this to the 1.84.0 milestone Nov 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 12, 2024
@rust-timer
Unrolled build for rust-lang#132901
7836ad4 
Rollup merge of rust-lang#132901 - clubby789:enable-pass-check, r=jieyouxu

Warn about invalid `mir-enable-passes` pass names

Fixes rust-lang#132805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

-Zmir-enable-passes= has no error handling

6 participants

@clubby789 @rustbot @rust-log-analyzer @jieyouxu @bors @compiler-errors