Update grammar in wasm-c-abi's compiler flag documentation#132824
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 10, 2024
Merged
Update grammar in wasm-c-abi's compiler flag documentation#132824bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
kadenlnelson
commented
Nov 9, 2024
kadenlnelson
commented
Nov 9, 2024
Member
|
Looks good to me, squash please? |
f4863b9 to
d6352a8
Compare
Co-authored-by: Jubilee <workingjubilee@gmail.com>
d6352a8 to
2ac1c18
Compare
Contributor
Author
Complete. |
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 10, 2024
Rollup merge of rust-lang#132824 - kadenlnelson:patch/wasi-c-abi-doc, r=workingjubilee Update grammar in wasm-c-abi's compiler flag documentation This PR adjusts the grammar of the `wasm-c-abi` compiler flag documentation. See the inline comments within the PR for details.
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
… r=workingjubilee Update grammar in wasm-c-abi's compiler flag documentation This PR adjusts the grammar of the `wasm-c-abi` compiler flag documentation. See the inline comments within the PR for details.
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#131258 (Stabilize s390x inline assembly) - rust-lang#132801 (interpret: get_alloc_info: also return mutability) - rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls) - rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation) - rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage) - rust-lang#132828 (Additional tests to ensure let is rejected during parsing) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the grammar of the
wasm-c-abicompiler flag documentation. See the inline comments within the PR for details.