serialize: add a few missing pubs to base64#13277
Closed
Arcterus wants to merge 1 commit intorust-lang:masterfrom
Arcterus:serialize-fix
Closed
serialize: add a few missing pubs to base64#13277Arcterus wants to merge 1 commit intorust-lang:masterfrom Arcterus:serialize-fix
Arcterus wants to merge 1 commit intorust-lang:masterfrom
Arcterus:serialize-fix
Conversation
Contributor
Author
|
I'm not sure why this is failing. |
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
Add `move_const_to_impl` assist Closes rust-lang#13277 For the initial implementation, this assist: - only applies to inherent impl. Much as we can *technically* provide this assist for default impl in trait definitions, it'd be complicated to get it right. - may break code when the const's name collides with an item of a trait the self type implements. Comments in the code explain those caveats in a bit more detail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the fields in
base64::Configpublic, which they were before the switch from fields being public by default to private by default.