fix(x): fix a regex used to find python executable#132694
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 7, 2024
ismailarilik:fix/x/fix-a-regex-used-to-find-python-executable
Merged
fix(x): fix a regex used to find python executable#132694bors merged 1 commit intorust-lang:masterfrom ismailarilik:fix/x/fix-a-regex-used-to-find-python-executable
bors merged 1 commit intorust-lang:masterfrom
ismailarilik:fix/x/fix-a-regex-used-to-find-python-executable
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
jieyouxu
approved these changes
Nov 7, 2024
Member
jieyouxu
left a comment
There was a problem hiding this comment.
Yes, [0-9]+ seems correct. Thanks!
gh-jieyouxu@dev-desktop-eu-1:~/rust$ compgen -c python
python3-config
python3.12-config
python
python3.12
python-dotenv
python3
python3-config
python3.12-config
python
python3.12
python-dotenv
python3
Member
|
r? jieyouxu @bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#132057 (miri: update ABI compat checks to accept Option-like types) - rust-lang#132665 (Implement `div_ceil` for `NonZero<unsigned>`) - rust-lang#132694 (fix(x): fix a regex used to find python executable) - rust-lang#132707 (Add --diagnostic-width to some tests failing after 1a0c502) - rust-lang#132715 (fix `LazyLock::get` and `LazyLock::get_mut` document) - rust-lang#132716 (chore(issue-template): fix branch name) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 7, 2024
Rollup merge of rust-lang#132694 - ismailarilik:fix/x/fix-a-regex-used-to-find-python-executable, r=jieyouxu fix(x): fix a regex used to find python executable Isn't the regex `^python[2-3]\.[0-9]\+$` wrong? It doesn't match, for example, with `python2.8`. There should be a plus sign at the end for a match, like `python2.8+`. I think `[0-9]+` is meant here instead of `[0-9]\+`. In that case a string like `python2.8` would match. This wasn't noticed because the script probably find and run the Python executable before this line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isn't the regex
^python[2-3]\.[0-9]\+$wrong? It doesn't match, for example, withpython2.8. There should be a plus sign at the end for a match, likepython2.8+. I think[0-9]+is meant here instead of[0-9]\+. In that case a string likepython2.8would match. This wasn't noticed because the script probably find and run the Python executable before this line.