Skip to content

Improve missing_abi lint#132357

Merged
bors merged 2 commits intorust-lang:masterfrom
m-ou-se:explicit-abi
Nov 1, 2024
Merged

Improve missing_abi lint#132357
bors merged 2 commits intorust-lang:masterfrom
m-ou-se:explicit-abi

Conversation

@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Oct 30, 2024 •
edited
Loading

This is for the migration lint for rust-lang/rfcs#3722

It is not yet marked as an edition migration lint, because Edition2027 doesn't exist yet.

The lint now includes a machine applicable suggestion:

warning: extern declarations without an explicit ABI are deprecated
 --> src/main.rs:3:1
  |
3 | extern fn a() {}
  | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
  |

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024
@m-ou-se m-ou-se mentioned this pull request Oct 30, 2024
Merged
@jieyouxu jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2024
compiler-errors
compiler-errors approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and happy to approve this if and when it is approved on the lang side.

Would like to see some explicit tests exercising that this does in fact error in edition 2024, and perhaps also exercising the error on free extern functions (extern fn() {}) vs extern blocks.

@compiler-errors
Copy link
Contributor

compiler-errors commented Oct 30, 2024 •
edited
Loading

Well, seems like from the RFC that this may be too late for 2024: rust-lang/rfcs#3722 (comment).

However, it would be very cool to pull out the edition-independent parts of this -- the change to make the suggestion applicable can still be applied to the lint, and storing the extern span seems nice to do anyways.

@m-ou-se m-ou-se added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. labels Oct 31, 2024
@m-ou-se m-ou-se marked this pull request as ready for review October 31, 2024 09:47
@m-ou-se
Copy link
Member Author

m-ou-se commented Oct 31, 2024 •
edited
Loading

Updated. Removed the edition stuff. This now just improves the lint. I'll send a separate PR to make it warn-by-default that can then be FCP'd.

@m-ou-se m-ou-se changed the title Require explicit ABI for extern in Rust 2024 Improve missing_abi lint Oct 31, 2024
@m-ou-se m-ou-se mentioned this pull request Oct 31, 2024
Merged
@compiler-errors
Copy link
Contributor

compiler-errors commented Oct 31, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 31, 2024

📌 Commit a433ea2 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 31, 2024
@matthiaskrgr
Rollup merge of rust-lang#132357 - m-ou-se:explicit-abi, r=compiler-e…
a7bdfe2 
…rrors

Improve missing_abi lint

This is for the migration lint for rust-lang/rfcs#3722

It is not yet marked as an edition migration lint, because `Edition2027` doesn't exist yet.

The lint now includes a machine applicable suggestion:

```
warning: extern declarations without an explicit ABI are deprecated
 --> src/main.rs:3:1
  |
3 | extern fn a() {}
  | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
  |
```
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 31, 2024
@bors
Auto merge of rust-lang#132420 - matthiaskrgr:rollup-w1vqgx9, r=matth…
3de9780 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#131168 (Fix `target_os` for `mipsel-sony-psx`)
 - rust-lang#132209 (Fix validation when lowering `?` trait bounds)
 - rust-lang#132357 (Improve missing_abi lint)
 - rust-lang#132385 (compiler: Move `rustc_target::spec::abi::Abi` to `rustc_abi::ExternAbi`)
 - rust-lang#132417 (macOS: Document the difference between Clang's `-darwin` and `-macosx` targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Nov 1, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2024
@bors
Auto merge of rust-lang#132435 - workingjubilee:rollup-3mgogw9, r=wor…
a8e1186 
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#131168 (Fix `target_os` for `mipsel-sony-psx`)
 - rust-lang#132209 (Fix validation when lowering `?` trait bounds)
 - rust-lang#132294 (Bump Fuchsia)
 - rust-lang#132357 (Improve missing_abi lint)
 - rust-lang#132385 (compiler: Move `rustc_target::spec::abi::Abi` to `rustc_abi::ExternAbi`)
 - rust-lang#132403 (continue `TypingMode` refactor)
 - rust-lang#132417 (macOS: Document the difference between Clang's `-darwin` and `-macosx` targets)
 - rust-lang#132421 (Remove `""` case from RISC-V `llvm_abiname` match statement)
 - rust-lang#132422 (llvm: Match new LLVM 128-bit integer alignment on sparc)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b0c8cf into rust-lang:master Nov 1, 2024
@rustbot rustbot added this to the 1.84.0 milestone Nov 1, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 1, 2024
@rust-timer
Unrolled build for rust-lang#132357
913a219 
Rollup merge of rust-lang#132357 - m-ou-se:explicit-abi, r=compiler-errors

Improve missing_abi lint

This is for the migration lint for rust-lang/rfcs#3722

It is not yet marked as an edition migration lint, because `Edition2027` doesn't exist yet.

The lint now includes a machine applicable suggestion:

```
warning: extern declarations without an explicit ABI are deprecated
 --> src/main.rs:3:1
  |
3 | extern fn a() {}
  | ^^^^^^ help: explicitly specify the C ABI: `extern "C"`
  |
```
@m-ou-se m-ou-se deleted the explicit-abi branch November 1, 2024 17:53
@traviscross traviscross added the L-missing_abi Lint: missing_abi label Jan 10, 2025
@traviscross traviscross mentioned this pull request Jan 10, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@compiler-errors compiler-errors compiler-errors approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errors compiler-errors

Labels

L-missing_abi Lint: missing_abi S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

7 participants

@m-ou-se @rustbot @compiler-errors @bors @traviscross @lcnr @jieyouxu