coverage: Emit LLVM intrinsics using the normal helper method#132125
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 25, 2024
Merged
coverage: Emit LLVM intrinsics using the normal helper method#132125bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
This comment has been minimized.
This comment has been minimized.
381729c to
8f07514
Compare
Collaborator
|
Some changes occurred in compiler/rustc_codegen_gcc |
Member
Author
|
Also removed a corresponding stubbed-out method from |
jieyouxu
approved these changes
Oct 25, 2024
Member
jieyouxu
left a comment
There was a problem hiding this comment.
This looks like a very nice cleanup, you can r=me after PR CI is green.
Member
Author
|
🟩 @bors r=jieyouxu |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#131457 (Expand `ptr::fn_addr_eq()` documentation.) - rust-lang#132085 (Update StableMIR doc to reflect current status) - rust-lang#132118 (Add support for `~const` item bounds) - rust-lang#132125 (coverage: Emit LLVM intrinsics using the normal helper method) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 25, 2024
Rollup merge of rust-lang#132125 - Zalathar:coverage-intrinsics, r=jieyouxu coverage: Emit LLVM intrinsics using the normal helper method Codegen already has convenient ways to declare and emit LLVM intrinsics, so there's no need for coverage instrumentation to jump through hoops to emit them manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codegen already has convenient ways to declare and emit LLVM intrinsics, so there's no need for coverage instrumentation to jump through hoops to emit them manually.