Skip locking span interner for some syntax context checks#128197
Merged
bors merged 1 commit intorust-lang:masterfrom Nov 15, 2024
Merged
Skip locking span interner for some syntax context checks#128197bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
davidtwco
reviewed
Aug 6, 2024
davidtwco
approved these changes
Nov 14, 2024
Member
davidtwco
left a comment
There was a problem hiding this comment.
Apologies that this was left waiting so long, this slipped through the cracks, thanks for making that change.
Member
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#128197 (Skip locking span interner for some syntax context checks) - rust-lang#133040 ([rustdoc] Fix handling of footnote reference in footnote definition) - rust-lang#133043 (rustdoc-search: case-sensitive only when capitals are used) - rust-lang#133046 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2024
Rollup merge of rust-lang#128197 - Alexendoo:span-ctxt, r=davidtwco Skip locking span interner for some syntax context checks - `from_expansion` now never needs to consult the interner - `eq_ctxt` now only needs the interner when both spans are fully interned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_expansionnow never needs to consult the internereq_ctxtnow only needs the interner when both spans are fully interned