test: Ignore some phase(syntax) tests#12659
Closed
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
Closed
test: Ignore some phase(syntax) tests#12659alexcrichton wants to merge 1 commit intorust-lang:masterfrom
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
Author
Member
Author
|
Perhaps things aren't getting cleaned, or perhaps this means that the SVH for i686 changed between stage{1,2}. I would rather get a new snap than block on investigation |
Member
|
The dependency tracking for fulldeps seems pretty broken to me, so I'm thinking it's probably just a cleaning issue. |
src/test/compile-fail/gated-phase.rs
Outdated
Member
There was a problem hiding this comment.
This test shouldn't need this, since it'll stop at feature gating.
Member
Author
There was a problem hiding this comment.
Aha, this was just failing locally due to some dependencies not getting built, reverted.
These tests are failing on the snap builders, and are now tagged with a FIXME. cc rust-lang#12102
Member
Author
|
A description of what I believe is going on: #12102 (comment) |
bors
added a commit
that referenced
this pull request
Mar 3, 2014
These tests are failing on the snap builders, and are now tagged with a FIXME. cc #12102
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix: Fix flycheck sending cancel progress with no running process Fixes rust-lang#12659
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 20, 2025
fixes: rust-lang#12659 [`manual_map`] and [`manual_filter`] shares the same check logic, but this issue doesn't seems like it could affect `manual_filter` (?) --- changelog: make [`manual_map`] ignore types that contain `dyn`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are failing on the snap builders, and are now tagged with a FIXME.
cc #12102