Make suggestion to change Fn to FnMut work with methods as well#126226
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 17, 2024
Merged
Make suggestion to change Fn to FnMut work with methods as well#126226bors merged 1 commit intorust-lang:masterfrom
Fn to FnMut work with methods as well#126226bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
Fn to FnMut work with methods wellFn to FnMut work with methods as well
Member
|
r? compiler |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2024
…llaumeGomez Rollup of 3 pull requests Successful merges: - rust-lang#126226 (Make suggestion to change `Fn` to `FnMut` work with methods as well) - rust-lang#126570 (Convert a `span_bug` to a `span_delayed_bug`.) - rust-lang#126580 (Add `run-make/const_fn_mir` missing test annotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 17, 2024
Rollup merge of rust-lang#126226 - gurry:125325-improve-closure-arg-sugg, r=oli-obk Make suggestion to change `Fn` to `FnMut` work with methods as well Fixes rust-lang#125325 The issue occurred because the code that emitted the suggestion to change `Fn` to `FnMut` worked only for function calls and not method calls. This PR makes it work with methods as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #125325
The issue occurred because the code that emitted the suggestion to change
FntoFnMutworked only for function calls and not method calls. This PR makes it work with methods as well.