Skip to content

[perf-only] Revert "Update expr matcher for Edition 2024 and add expr_2021 nonterminal"#125389

Closed
fmease wants to merge 6 commits intorust-lang:masterfrom
fmease:perf-expr_2021
Closed

[perf-only] Revert "Update expr matcher for Edition 2024 and add expr_2021 nonterminal"#125389
fmease wants to merge 6 commits intorust-lang:masterfrom
fmease:perf-expr_2021

Conversation

@fmease
Copy link
Member

@fmease fmease commented May 21, 2024 •
edited
Loading

CC #123865
r? ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2024
@fmease
Copy link
Member Author

fmease commented May 21, 2024

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 21, 2024
@fmease fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2024
@bors
Auto merge of rust-lang#125389 - fmease:perf-expr_2021, r=<try>
428af23 
[perf-only] Revert "Update `expr` matcher for Edition 2024 and add `expr_2021` nonterminal"

CC rust-lang#123865
r? ghost
@bors
Copy link
Collaborator

bors commented May 21, 2024

⌛ Trying commit e8d39b6 with merge 428af23...

@bors
Copy link
Collaborator

bors commented May 22, 2024

☀️ Try build successful - checks-actions
Build commit: 428af23 (428af23f7fdca618ff29c537b7666c6a06b26d7e)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented May 22, 2024

Finished benchmarking commit (428af23): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.5%, -0.3%] 8
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.076s -> 671.009s (-0.01%)
Artifact size: 315.42 MiB -> 316.20 MiB (0.25%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 22, 2024
@fmease fmease mentioned this pull request May 23, 2024
Merged
@fmease fmease closed this May 31, 2024
@fmease fmease deleted the perf-expr_2021 branch May 31, 2024 18:49
@fmease fmease mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fmease @rust-timer @bors @rustbot