Clarify how String::leak and into_boxed_str differ #125251
Clarify how String::leak and into_boxed_str differ #125251bors merged 1 commit intorust-lang:masterfrom
Conversation
|
r? @Nilstrieb rustbot has assigned @Nilstrieb. Use |
This comment has been minimized.
This comment has been minimized.
|
I don't think this change really matches the PR description, it doesn't really make it much clearer what it's useful for. Still, this is a good docs improvement that I'm happy to approve (after you squashed the commits and CI passes). |
Heh, apologies for that, I was encouraged ( 👀 ) to submit this while doing a live stream, and so my attention to detail is somewhat compromised. Have squashed now and updated the title 👍 |
|
@bors rollup |
|
@jonhoo: 🔑 Insufficient privileges: not in try users |
|
Figured I could pro-actively mark this as a fine to roll up, but I guess not 😅 |
|
i can do that for you :3, thank you for the PR! |
Rollup of 3 pull requests Successful merges: - rust-lang#125214 (Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability) - rust-lang#125236 (Add tests for `-Zunpretty=expanded` ported from stringify's tests) - rust-lang#125251 (Clarify how String::leak and into_boxed_str differ ) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125251 - jonhoo:patch-1, r=Nilstrieb Clarify how String::leak and into_boxed_str differ
No description provided.