Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects#124871
Merged
bors merged 1 commit intorust-lang:masterfrom May 16, 2024
Merged
Conversation
Collaborator
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
lcnr
reviewed
May 8, 2024
Contributor
lcnr
left a comment
There was a problem hiding this comment.
I just realized: BestObligation<'tcx>::visit_goal always returns ControlFLow::Break, doesn't it? This means that in the for nested_goals loops, we always just use the first nested ImplWhereBound of the loop 🤔 this is surprising and means the impl_where_bound_count is actually unused?
| candidates.retain(|candidate| candidate.result().is_ok()); | ||
| } | ||
| false => { | ||
| candidates.retain(|candidate| candidate.result().is_err()); |
Contributor
There was a problem hiding this comment.
this retain feels off: I would expecct us to never fail if there are any non-err candidates 🤔
Contributor
Author
There was a problem hiding this comment.
Yeah, it's probably useless.
Contributor
There was a problem hiding this comment.
pls remove it or change it to an assert then 🤔
Contributor
Author
Not if we have an ambig impl where bound then an err impl where bound. |
…ligation causes inference side-effects
d3f570b to
d3e510e
Compare
Contributor
Author
|
@bors r=lcnr rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124871 (Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects) - rust-lang#125018 (Update linker-plugin-lto.md to include LLVM 18) - rust-lang#125130 (rustdoc-json-types: Document `Id`) - rust-lang#125170 (Uplift `FnSig` into `rustc_type_ir` (redux)) - rust-lang#125172 (Fix assertion when attempting to convert `f16` and `f128` with `as`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 16, 2024
Rollup merge of rust-lang#124871 - compiler-errors:overflowo, r=lcnr Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects See the comments for more info. Reprocessing overflowed obligations may cause *other* goals to go from ambig -> pass/fail, causing an ICE. This suppresses that error, but makes all the overflow obligations messages back to their root obl. That kinda sucks, but 🤷 Fixes rust-lang#124834 Fixes rust-lang#124845 r? lcnr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comments for more info. Reprocessing overflowed obligations may cause other goals to go from ambig -> pass/fail, causing an ICE. This suppresses that error, but makes all the overflow obligations messages back to their root obl. That kinda sucks, but 🤷
Fixes #124834
Fixes #124845
r? lcnr