PatRangeBoundary::compare_with: als add a fast-path for signed integers#124190
PatRangeBoundary::compare_with: als add a fast-path for signed integers#124190bors merged 1 commit intorust-lang:masterfrom
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> PatRangeBoundary::compare_with: als add a fast-path for signed integers Not sure if we have a benchmark that hits this... but it seems odd to only do this for unsigned integers.
|
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f937f6f): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.156s -> 670.23s (0.01%) |
|
Seems like we don't have a benchmark. Or is there some reason this would not actually be helpful? Cc @Nadrieril since you've been doing a bunch of work on THIR patterns recently. |
|
Yeah, I've seen this fast path around for a while. I think it impacts the unicode_normalization benchmark which only exercises the unsigned case. If it's useful for unsigned, it's useful for signed surely. @bors r+ |
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c3ceb00): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 672.18s -> 672.07s (-0.02%) |
Not sure if we have a benchmark that hits this... but it seems odd to only do this for unsigned integers.