Skip to content

Update LLVM to 1deeee3#124044

Merged
bors merged 1 commit intorust-lang:masterfrom
dianqk:update-llvm-18
Apr 18, 2024
Merged

Update LLVM to 1deeee3#124044
bors merged 1 commit intorust-lang:masterfrom
dianqk:update-llvm-18

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Apr 16, 2024

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2024
@cuviper
Copy link
Member

cuviper commented Apr 16, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Apr 16, 2024

📌 Commit 374b782 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 16, 2024

bors rollup=neeeev3r

@dianqk
Copy link
Member Author

dianqk commented Apr 17, 2024 •
edited
Loading

Oh no, version 18.1.4 has already been released just now. The new changes don't seem important: llvm/llvm-project@1deeee3...e6c3289.

Hmm, it includes another MIPS commit. I think it's easier to consider a backport while keeping the current state.

@bors
Copy link
Collaborator

bors commented Apr 18, 2024

⌛ Testing commit 374b782 with merge 9f432d7...

@dianqk dianqk mentioned this pull request Apr 18, 2024
Merged
@dianqk
Copy link
Member Author

dianqk commented Apr 18, 2024

Replace #124044 with this PR.

@rustbot label beta-nominated T-compiler

@rustbot rustbot added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 18, 2024
@bors
Copy link
Collaborator

bors commented Apr 18, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 9f432d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2024
@bors bors merged commit 9f432d7 into rust-lang:master Apr 18, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 18, 2024
@dianqk dianqk deleted the update-llvm-18 branch April 18, 2024 02:17
@rust-timer
Copy link
Collaborator

rust-timer commented Apr 18, 2024

Finished benchmarking commit (9f432d7): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.135s -> 676.169s (-0.14%)
Artifact size: 316.09 MiB -> 316.07 MiB (-0.01%)

@apiraino
Copy link
Contributor

apiraino commented Apr 18, 2024

Beta backport declined as per compiler team on Zulip.

We're not sure this backport aligns with our backport policies (which btw are a bit unclear) and because maybe it doesn't feel that urgent (besides fixing a regression we introduced in the latest LLVM upgrade on a tier 3 platform). The overlap with LLVM upgrade to 1.8.1.4. add also a bit of uncertainity.

@rustbot label -beta-nominated

@rustbot rustbot removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 18, 2024
@workingjubilee workingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.79.0

Development

Successfully merging this pull request may close these issues.

[MIPS] AtomicI8 and AtomicI16 doctests for fn fetch_min() and fn fetch_max() began failing in nightly-2024-04-08

8 participants

@dianqk @rustbot @cuviper @bors @matthiaskrgr @rust-timer @apiraino @workingjubilee