Simplify `static_assert_size`s. by nnethercote · Pull Request #124008 · rust-lang/rust

nnethercote · 2024-04-16T07:03:08Z

We want to run them on all 64-bit platforms.

r? @ghost

rustbot · 2024-04-16T07:03:12Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

nnethercote · 2024-04-16T07:03:16Z

@bors try

…ze, r=<try> Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`

bors · 2024-04-16T07:04:28Z

⌛ Trying commit 54f8f52 with merge 63f3962...

Noratrieb · 2024-04-16T08:25:01Z

i don't think the try build will be useful as it only runs x86-64 linux, but now I can't approve it :D
r=me after the try build is over

nnethercote · 2024-04-16T08:33:07Z

So should we just mark as a non-rollup, let it attempt the merge, and see if anything fails then?

bors · 2024-04-16T08:36:36Z

☀️ Try build successful - checks-actions
Build commit: 63f3962 (63f3962ab602ee3449789ca7509ab405a2421f3e)

Noratrieb · 2024-04-16T08:46:29Z

yeah, that's how we figure out what happens
@bors r+ rollup=iffy

bors · 2024-04-16T08:46:32Z

📌 Commit 54f8f52 has been approved by Nilstrieb

It is now in the queue for this repository.

…ze, r=Nilstrieb Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`

bors · 2024-04-17T23:14:34Z

⌛ Testing commit 54f8f52 with merge 0e3de81...

bors · 2024-04-17T23:50:26Z

💔 Test failed - checks-actions

saethlin · 2024-04-18T01:35:08Z

The problem here is the size difference of PathBuf on Windows, because internally it has an extra bool.

It would be neat to bit-pack this away:

rust/library/std/src/sys_common/wtf8.rs

Lines 136 to 146 in becebb3

    
           pub struct Wtf8Buf { 
        
               bytes: Vec<u8>, 
        
               /// Do we know that `bytes` holds a valid UTF-8 encoding? We can easily 
        
               /// know this if we're constructed from a `String` or `&str`. 
        
               /// 
        
               /// It is possible for `bytes` to have valid UTF-8 without this being 
        
               /// set, such as when we're concatenating `&Wtf8`'s and surrogates become 
        
               /// paired, as we don't bother to rescan the entire string. 
        
               is_known_utf8: bool, 
        
           }

We want to run them on all 64-bit platforms.

nnethercote · 2024-04-18T05:38:07Z

The problem here is the size difference of PathBuf on Windows, because internally it has an extra bool.

I have updated that assertion accordingly. Let's try again...

@bors r=Nilstrieb

bors · 2024-04-18T05:38:10Z

📌 Commit 0d97669 has been approved by Nilstrieb

It is now in the queue for this repository.

bors · 2024-04-18T09:47:48Z

⌛ Testing commit 0d97669 with merge c25473f...

bors · 2024-04-18T11:48:42Z

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing c25473f to master...

rust-timer · 2024-04-18T13:05:45Z

Finished benchmarking commit (c25473f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.014s -> 676.875s (-0.17%)
Artifact size: 315.34 MiB -> 315.38 MiB (0.01%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 16, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2024

Auto merge of rust-lang#124008 - nnethercote:simpler-static_assert_si…

63f3962

…ze, r=<try> Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024

Auto merge of rust-lang#124008 - nnethercote:simpler-static_assert_si…

0e3de81

…ze, r=Nilstrieb Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2024

Simplify static_assert_sizes.

0d97669

We want to run them on all 64-bit platforms.

nnethercote force-pushed the simpler-static_assert_size branch from 54f8f52 to 0d97669 Compare April 18, 2024 05:36

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2024

bors merged commit c25473f into rust-lang:master Apr 18, 2024

rustbot added this to the 1.79.0 milestone Apr 18, 2024

bors mentioned this pull request Apr 18, 2024

rustdoc: link sibling where possible, even when not One True Path #124102

Closed

nnethercote deleted the simpler-static_assert_size branch April 18, 2024 23:50

Uh oh!

Conversation

nnethercote commented Apr 16, 2024

Uh oh!

rustbot commented Apr 16, 2024

Uh oh!

nnethercote commented Apr 16, 2024

Uh oh!

bors commented Apr 16, 2024

Uh oh!

Noratrieb commented Apr 16, 2024

Uh oh!

nnethercote commented Apr 16, 2024

Uh oh!

bors commented Apr 16, 2024

Uh oh!

Noratrieb commented Apr 16, 2024

Uh oh!

bors commented Apr 16, 2024

Uh oh!

bors commented Apr 17, 2024

Uh oh!

This comment has been minimized.

bors commented Apr 17, 2024

Uh oh!

saethlin commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nnethercote commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

bors commented Apr 18, 2024

Uh oh!

rust-timer commented Apr 18, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

saethlin commented Apr 18, 2024 •

edited

Loading