Deny gen keyword in edition_2024_compat lints#123680
Conversation
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ehuss: Do you know what's the order of operations for fixing things in the edition-guide submodule? Seems like I need to fix the guide to point to |
|
Hm, I don't think we've had a situation quite like this. Ideally the links shouldn't be broken, since there can be other pages outside of our docs linking to it. My instinct would be to add a short-term solution to the lint-docs tool to redirect renamed lints to the new location, and to just manually list those for now. I can probably put that together. The longer term thinking is to embed all the lint data and docs in |
This comment has been minimized.
This comment has been minimized.
Nadrieril
left a comment
There was a problem hiding this comment.
Implementation looks good. Is it just the guide submodule left to figure out?
|
Yup |
|
Ok. r=me when you figure that out |
|
Opened #123986 to unblock this. |
lint-docs: Add redirects for renamed lints. This updates the lint docs to include a redirect for renamed lints to the new name. This helps ensure that links to the old name will still be valid. Note that this currently uses a hard-coded list. As mentioned in the comment, a future enhancement may gather this information in a better way. Unblocks rust-lang#123680
lint-docs: Add redirects for renamed lints. This updates the lint docs to include a redirect for renamed lints to the new name. This helps ensure that links to the old name will still be valid. Note that this currently uses a hard-coded list. As mentioned in the comment, a future enhancement may gather this information in a better way. Unblocks rust-lang#123680
Rollup merge of rust-lang#123986 - ehuss:lint-renamed, r=Mark-Simulacrum lint-docs: Add redirects for renamed lints. This updates the lint docs to include a redirect for renamed lints to the new name. This helps ensure that links to the old name will still be valid. Note that this currently uses a hard-coded list. As mentioned in the comment, a future enhancement may gather this information in a better way. Unblocks rust-lang#123680
620cfdf to
4c3e02c
Compare
This comment has been minimized.
This comment has been minimized.
|
Is this ready now? |
|
Yup! @bors r=Nadrieril |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123680 (Deny gen keyword in `edition_2024_compat` lints) - rust-lang#124057 (Fix ICE when ADT tail has type error) - rust-lang#124168 (Use `DefiningOpaqueTypes::Yes` in rustdoc, where the `InferCtxt` is guaranteed to have no opaque types it can define) - rust-lang#124197 (Move duplicated code in functions in `tests/rustdoc-gui/notable-trait.goml`) - rust-lang#124200 (Improve handling of expr->field errors) - rust-lang#124220 (Miri: detect wrong vtables in wide pointers) - rust-lang#124266 (remove an unused type from the reentrant lock tests) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123680 - compiler-errors:gen-kw, r=Nadrieril Deny gen keyword in `edition_2024_compat` lints Splits the `keyword_idents` lint into two -- `keyword_idents_2018` and `keyword_idents_2024` -- since each corresponds to a future-compat warning in a different edition. Group these together into a new `keyword_idents` lint group, and add the latter to the `rust_2024_compatibility` so that `gen` is ready for the 2024 edition. cc `@traviscross` `@ehuss`
Splits the
keyword_identslint into two --keyword_idents_2018andkeyword_idents_2024-- since each corresponds to a future-compat warning in a different edition. Group these together into a newkeyword_identslint group, and add the latter to therust_2024_compatibilityso thatgenis ready for the 2024 edition.cc @traviscross @ehuss