compiletest: print reason for failing to read tests#123224
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 30, 2024
Merged
compiletest: print reason for failing to read tests#123224bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @albertlarsan68. Use |
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Contributor
|
@bors r+ |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 30, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#121573 (unix_sigpipe: Add test for SIGPIPE disposition in child processes) - rust-lang#123170 (Replace regions in const canonical vars' types with `'static` in next-solver canonicalizer) - rust-lang#123200 (KCFI: Require -C panic=abort) - rust-lang#123201 (Improve wording in std::any explanation) - rust-lang#123224 (compiletest: print reason for failing to read tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 30, 2024
Rollup merge of rust-lang#123224 - pacak:better-error-message, r=compiler-errors compiletest: print reason for failing to read tests Turns this ``` Could not read tests from /path/to/rust/tests/run-make note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Build completed unsuccessfully in 0:00:05 ``` into this: ``` Could not read tests from /path/to/rust/tests/run-make: run-make tests cannot have both `Makefile` and `rmake.rs` note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace Build completed unsuccessfully in 0:00:05 ``` While first one is technically correct - it's not helpful at all, adding backtrace is not making it any better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns this
into this:
While first one is technically correct - it's not helpful at all, adding backtrace is not making it any better.