Move option_env! and env! tests to the env-macro directory#122657
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 18, 2024
Merged
Move option_env! and env! tests to the env-macro directory#122657bors merged 1 commit intorust-lang:masterfrom
option_env! and env! tests to the env-macro directory#122657bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use r? to explicitly pick a reviewer |
Member
|
Thanks! Can you move them both to a new |
86f21ab to
3651401
Compare
option_env! tests to their own directoryoption_env! and env! tests to the env-macro directory
Contributor
Author
|
@Nilstrieb Done |
Contributor
|
@bors r=compiler-errors,Nilstrieb rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#122639 (Fix typos) - rust-lang#122654 (interpret/memory: explain why we use == on bool) - rust-lang#122656 (simplify_cfg: rename some passes so that they make more sense) - rust-lang#122657 (Move `option_env!` and `env!` tests to the `env-macro` directory) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
Rollup merge of rust-lang#122657 - beetrees:option-env-tests, r=compiler-errors,Nilstrieb Move `option_env!` and `env!` tests to the `env-macro` directory This PR moves the `option_env!` tests to there own directory (`extoption_env`), matching the naming convention used by the tests for `env!` (which live in the `extenv` directory).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
option_env!tests to there own directory (extoption_env), matching the naming convention used by the tests forenv!(which live in theextenvdirectory).