std::comm: replace Handle.id with a method.#12225
Closed
huonw wants to merge 1 commit intorust-lang:masterfrom
Closed
std::comm: replace Handle.id with a method.#12225huonw wants to merge 1 commit intorust-lang:masterfrom
huonw wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
Member
There was a problem hiding this comment.
I'd like to keep this actually because I'm pretty sure select!() will assert, and it also doesn't quite make much sense. Perhaps the * could also become a + though!
Contributor
Author
There was a problem hiding this comment.
I.e. Select requires at least 1 element?
The `id` shouldn't be changed by external code, and exposing it publicly allows to be accidentally changed. Also, remove the first element special case in the `select!` macro.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
internal: Add token mapping test for float literals cc rust-lang/rust-analyzer#12216
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 8, 2024
[`redundant_locals`]: take by-value closure captures into account Fixes rust-lang#12225 The same problem in the linked issue can happen to regular closures too, and conveniently async blocks are closures in the HIR so fixing closures will fix async blocks as well. changelog: [`redundant_locals`]: avoid linting when redefined variable is captured by-value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
idshouldn't be changed by external code, and exposing it publiclyallows it to be accidentally changed.
Also, remove the first element special case in the
select!macro.