Comment out change-id in config.example.toml#119080
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 18, 2023
Merged
Conversation
This way, we only update CONFIG_CHANGE_HISTORY for major changes, which is much simpler (and updating example.toml doesn't make much sense) Signed-off-by: onur-ozkan <work@onurozkan.dev>
Collaborator
|
This PR modifies If appropriate, please update |
Member
|
Looks good to me. My original idea was to actually put the latest value of Since bootstrap anyway tells us if @bors r+ rollup |
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2023
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#118941 (llvm-wrapper: adapt for LLVM API changes) - rust-lang#119068 (Copy 1.74.1 release notes to master) - rust-lang#119080 (Comment out `change-id` in `config.example.toml`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 18, 2023
Rollup merge of rust-lang#119080 - onur-ozkan:comment-change-id-in-example-config, r=Kobzol Comment out `change-id` in `config.example.toml` This way, we only update CONFIG_CHANGE_HISTORY for major changes, which is much simpler (and updating example.toml doesn't make much sense) r? `@Kobzol` (as this was mainly your idea)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, we only update CONFIG_CHANGE_HISTORY for major changes, which is much simpler (and updating example.toml doesn't make much sense)
r? @Kobzol (as this was mainly your idea)