Rename std::borrow to std::reference.#11895
Merged
bors merged 3 commits intorust-lang:masterfrom Jan 30, 2014
Merged
Conversation
Contributor
Author
|
to_uint and ref_eq are hardly used (about 3 times or so), and are very short. Possibly candidates for removal? |
Member
|
Interesting! I wonder if this module can just be removed entirely? Either that, or this could become a private module to contain the impls and the functions wouldn't be accessible any more. I feel like the functions do kinda have questionable utility... |
Contributor
|
👍 |
Contributor
|
Wow, first you removed |
Contributor
|
Just copy the implementation if you really need it; it's one line. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 16, 2023
Useless vec false positive changelog: [`useless_vec`]: fix false positive in macros. fixes rust-lang#11861 We delay the emission of `useless_vec` lints to the check_crate_post stage, which allows us to effectively undo lints if we find that a `vec![]` expression is being used multiple times after macro expansion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11814