Make exhaustiveness usable outside of rustc by Nadrieril · Pull Request #118842 · rust-lang/rust

Nadrieril · 2023-12-11T23:03:03Z

With this PR, rustc_pattern_analysis compiles on stable (with the stable feature)! rust-analyzer will be able to use it to provide match-related diagnostics and refactors.

Two questions:

Should I name the feature nightly instead of rustc for consistency with other crates? rustc makes more sense imo.
typed-arena is an optional dependency but tidy made me add it to the allow-list anyway. Can I avoid that somehow?

r? @compiler-errors

rustbot · 2023-12-11T23:03:13Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Nadrieril · 2023-12-11T23:04:00Z

typed-arena is MIT licensed btw

Nadrieril · 2023-12-11T23:06:13Z

Bracing myself for perf sadness

@bors try @rust-timer queue

bors · 2023-12-11T23:07:22Z

⌛ Trying commit 5d7b823 with merge 6c25005...

Make exhaustiveness usable outside of rustc With this PR, `rustc_pattern_analysis` compiles on stable (with the `stable` feature)! `rust-analyzer` will be able to use it to provide match-related diagnostics and refactors. Two questions: - Should I name the feature `nightly` instead of `rustc` for consistency with other crates? `rustc` makes more sense imo. - `typed-arena` is an optional dependency but tidy made me add it to the allow-list anyway. Can I avoid that somehow? r? `@compiler-errors`

bors · 2023-12-12T00:34:34Z

☀️ Try build successful - checks-actions
Build commit: 6c25005 (6c25005174ed8f066e244b3d08df28671ed44189)

rust-timer · 2023-12-12T03:22:28Z

Finished benchmarking commit (6c25005): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.8%, 1.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.1%, 3.6%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.051s -> 672.417s (0.05%)
Artifact size: 314.25 MiB -> 314.30 MiB (0.02%)

compiler/rustc_pattern_analysis/src/constructor.rs

compiler/rustc_pattern_analysis/src/pat.rs

compiler/rustc_pattern_analysis/src/lib.rs

compiler/rustc_pattern_analysis/src/constructor.rs

compiler/rustc_pattern_analysis/src/rustc.rs

compiler/rustc_pattern_analysis/src/lib.rs

compiler/rustc_pattern_analysis/src/lints.rs

compiler-errors · 2023-12-17T18:29:37Z

I will review this on Monday probably

compiler-errors

Please address these in a follow-up commit

compiler-errors · 2023-12-19T16:06:06Z

compiler/rustc_pattern_analysis/src/lib.rs

+/// Context that provides type information about constructors.
+///
+/// Most of the crate is parameterized on a type that implements this trait.
+pub trait TypeCx: Sized + Clone + fmt::Debug {


You shouldn't need a Clone supertrait here.

compiler-errors · 2023-12-19T16:06:38Z

compiler/rustc_pattern_analysis/src/lib.rs

+}
+
+/// Context that provides information global to a match.
+#[derive(Clone)]


you can use derivative like rustc_type_ir to avoid needing to 1. manual Copy impl and 2. Clone that requires Cx: Clone.

Oh nice I didn't know we used derivative

compiler-errors · 2023-12-19T16:10:29Z

@bors r+

bors · 2023-12-19T16:10:32Z

📌 Commit 3016c29 has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2023-12-19T16:10:35Z

@bors rollup=never

fbstj · 2023-12-19T16:53:55Z

compiler/rustc_index/src/bit_set.rs

+                    #[cfg(feature = "nightly")]
+                    let mut words = {
+                        // We take some effort to avoid copying the words.
+                        let words = Rc::<[Word; CHUNK_WORDS]>::new_zeroed();


does this deserve a TODO that points to a tracking issue?

@Nadrieril should add this to a follow-up PR if it matters.

bors · 2023-12-19T17:15:08Z

⌛ Testing commit 3016c29 with merge 3a539c0...

bors · 2023-12-19T19:16:18Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 3a539c0 to master...

rust-timer · 2023-12-19T20:37:57Z

Finished benchmarking commit (3a539c0): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 1.0%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[0.6%, 3.6%]	2
Regressions ❌ (secondary)	3.5%	[3.5%, 3.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	2.1%	[0.6%, 3.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.5%, 3.4%]	6
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.5%	[-0.5%, -0.5%]	2

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 671.842s -> 673.86s (0.30%)
Artifact size: 312.46 MiB -> 312.43 MiB (-0.01%)

…r=compiler-errors Exhaustiveness: clean up after librarification This cleans up some things that weren't done nicely by rust-lang#118842. r? `@compiler-errors`

Rollup merge of rust-lang#119230 - Nadrieril:librarify-even-further, r=compiler-errors Exhaustiveness: clean up after librarification This cleans up some things that weren't done nicely by rust-lang#118842. r? `@compiler-errors`

…r-errors Exhaustiveness: clean up after librarification This cleans up some things that weren't done nicely by rust-lang/rust#118842. r? `@compiler-errors`

Kobzol · 2023-12-26T09:38:15Z

Small regression to a single stress test benchmark. Worth the librarification effort, I don't think that we need to dive further into this.

@rustbot label: +perf-regression-triaged

rustbot assigned compiler-errors Dec 11, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 11, 2023

Nadrieril added A-exhaustiveness-checking Relating to exhaustiveness / usefulness checking of patterns and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Dec 11, 2023

Nadrieril mentioned this pull request Dec 11, 2023

More changes for splitting exhaustiveness into a crate Nadrieril/rust#1

Closed

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 12, 2023

compiler-errors reviewed Dec 14, 2023

View reviewed changes

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 14, 2023

Nadrieril added 8 commits December 15, 2023 16:57

Split Single ctor into more specific variants

b111b2e

Remove all matching on ty.kind() outside cx

081c3dc

Disentangle the arena from MatchCheckCtxt

3ad76f9

Abstract MatchCheckCtxt into a trait

3d7c4df

Name rustc-specific things "rustc"

cb622f3

Iron out last rustc-specific details

42f4393

Gate rustc-specific code under a feature

16bd6ac

Make the rustc_data_structures dependency optional

e646c9f

Introduce MatchCtxt

4bcf66f

Nadrieril force-pushed the librarify-further branch from ce45b48 to a6a944d Compare December 15, 2023 16:25

s/MatchCx/TypeCx/

3016c29

Nadrieril force-pushed the librarify-further branch from a6a944d to 3016c29 Compare December 15, 2023 16:26

compiler-errors approved these changes Dec 19, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2023

fbstj reviewed Dec 19, 2023

View reviewed changes

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 19, 2023

bors merged commit 3a539c0 into rust-lang:master Dec 19, 2023

rustbot added this to the 1.76.0 milestone Dec 19, 2023

This was referenced Dec 19, 2023

Add f16 and f128 #114607

Closed

Exhaustiveness: reveal opaque types properly #116821

Merged

Nadrieril deleted the librarify-further branch December 19, 2023 19:56

This was referenced Dec 19, 2023

Exhaustiveness: Improve complexity on some wide matches #118796

Merged

Add the min_exhaustive_patterns feature gate #118803

Merged

Lint singleton gaps after exclusive ranges #118879

Merged

Nadrieril mentioned this pull request Dec 22, 2023

Exhaustiveness: clean up after librarification #119230

Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 26, 2023

Uh oh!

Conversation

Nadrieril commented Dec 11, 2023

Uh oh!

rustbot commented Dec 11, 2023

Uh oh!

Nadrieril commented Dec 11, 2023

Uh oh!

Nadrieril commented Dec 11, 2023

Uh oh!

This comment has been minimized.

bors commented Dec 11, 2023

Uh oh!

bors commented Dec 12, 2023

Uh oh!

This comment has been minimized.

rust-timer commented Dec 12, 2023

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Dec 17, 2023

Uh oh!

compiler-errors left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Dec 19, 2023

Uh oh!

bors commented Dec 19, 2023

Uh oh!

compiler-errors commented Dec 19, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bors commented Dec 19, 2023

Uh oh!

bors commented Dec 19, 2023

Uh oh!

rust-timer commented Dec 19, 2023

Overall result: ❌ regressions - ACTION NEEDED

Uh oh!

Kobzol commented Dec 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants