[rustdoc] Don't generate the "Fields" heading if there is no field displayed#118600
Merged
bors merged 2 commits intorust-lang:masterfrom Dec 5, 2023
Merged
[rustdoc] Don't generate the "Fields" heading if there is no field displayed#118600bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
notriddle
reviewed
Dec 4, 2023
Contributor
|
@bors r+ rollup |
Collaborator
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 4, 2023
…otriddle [rustdoc] Don't generate the "Fields" heading if there is no field displayed Fixes rust-lang#118195. If no field is displayed, we should not generate the `Fields` heading in enum struct variants. r? `@notriddle`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118076 (Tweak `.clone()` suggestion to work in more cases) - rust-lang#118508 (rustdoc: do not escape quotes in body text) - rust-lang#118565 (interpret: make numeric_intrinsic accessible from Miri) - rust-lang#118591 (portable-simd: fix test suite build) - rust-lang#118600 ([rustdoc] Don't generate the "Fields" heading if there is no field displayed) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2023
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#118508 (rustdoc: do not escape quotes in body text) - rust-lang#118565 (interpret: make numeric_intrinsic accessible from Miri) - rust-lang#118591 (portable-simd: fix test suite build) - rust-lang#118600 ([rustdoc] Don't generate the "Fields" heading if there is no field displayed) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
Rollup merge of rust-lang#118600 - GuillaumeGomez:fields-heading, r=notriddle [rustdoc] Don't generate the "Fields" heading if there is no field displayed Fixes rust-lang#118195. If no field is displayed, we should not generate the `Fields` heading in enum struct variants. r? ``@notriddle``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118195.
If no field is displayed, we should not generate the
Fieldsheading in enum struct variants.r? @notriddle