Add ASCII whitespace trimming functions to &str#118523
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 16, 2023
Merged
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Member
|
Marking as waiting on team, since there's no T-libs-api ACP or other sign off for this new unstable surface area. |
Contributor
Author
|
Filed an ACP I didn't initially file one because the dev guide made it seem more optional than required. |
Member
|
Discussed in today's @rust-lang/libs-api meeting, and we decided to accept these. We can evaluate further during stabilization. |
Member
|
It's probably best to use the same tracking issue as for the |
Add `trim_ascii_start`, `trim_ascii_end`, and `trim_ascii` functions to `&str` for trimming ASCII whitespace under the `byte_slice_trim_ascii` feature gate. Add `inline` to `[u8]` `trim_ascii` functions
Contributor
Author
|
Put these functions under the |
Contributor
Author
|
@rustbot label -S-waiting-on-team +S-waiting-on-review |
Member
|
@bors r+ |
Collaborator
5 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2023
…kingjubilee Rollup of 6 pull requests Successful merges: - rust-lang#118523 (Add ASCII whitespace trimming functions to `&str`) - rust-lang#118851 ([std] Add xcoff in object's feature list) - rust-lang#118989 (Simplify lint decorator derive too) - rust-lang#118993 (use `if cfg!` instead of `#[cfg]`) - rust-lang#119003 (NFC: do not clone types that are copy) - rust-lang#119004 (NFC don't convert types to identical types) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2023
Rollup merge of rust-lang#118523 - okaneco:trim_ascii, r=Mark-Simulacrum Add ASCII whitespace trimming functions to `&str` - Add `trim_ascii_start`, `trim_ascii_end`, and `trim_ascii` functions to `&str` for trimming ASCII whitespace - Add `#[inline]` to `[u8]` `trim_ascii` functions These functions are feature-gated by `#![feature(byte_slice_trim_ascii)]` rust-lang#94035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trim_ascii_start,trim_ascii_end, andtrim_asciifunctions to&strfor trimming ASCII whitespace#[inline]to[u8]trim_asciifunctionsThese functions are feature-gated by
#![feature(byte_slice_trim_ascii)]#94035